SQL warning at top of page for anonymous users

I think this is due to a bug in a query in Drupal core that has been fixed. Try updating to the latest 5.x:

http://drupal.org/drupal-5.x-dev

the point is the table alias in the query, not the table structure. Did you use the link above to download Drupal?

I'm having this exact same problem with anonymous users only. Can you be more specific as to what I need to upgrade? I have Drupal 5.1, which is almost the newest. If you're suggesting I have to upgrade to 5.2, I'm a little hesitant as this was a fantastico install and I don't want to take any chances, especially with all the modules I have, before I even launch my site. Any ideas? Thank you.

-Could I try using an older version of modr8?

Anyone have any ideas for this? Is there a supposed database upgrade script that I can run that doesn't involve upgrading my Drupal 5.1 to 5.2?

I submitted the patch to core that went in for 5.3 to fix this problem. The issue is that a db_rewrite_sql call in the core comment handling code is failing to pass the primary_table and primary_field arguments. These default to "n" and "nid" and assume that the query contains the node table, that the node table is called 'n' and that the nid field on that table is 'nid'.

But the query is for node comment stats and does not contain the node. Modules like modr8 assume that any query where the primary table is named "n" contains a node and then inject additional SQL into the query based on that assumption. Modr8 is not broken here, core is.

If you want to make a local patch open up comment.module and apply the following change (find the line with the -, change it to look like the line with the +)

-  $result = db_query_range(db_rewrite_sql("SELECT n.nid FROM {node_comment_statistics} n WHERE n.comment_count > 0 ORDER BY n.last_comment_timestamp DESC"), 0, $number);
+  $result = db_query_range(db_rewrite_sql("SELECT ncs.nid FROM {node_comment_statistics} ncs WHERE ncs.comment_count > 0 ORDER BY ncs.last_comment_timestamp DESC", 'ncs'), 0, $number);

This should do it for you.

Scott

I have Drupal 5.10 installed and I'm getting the error:

user warning: Unknown column 'n.moderate' in 'where clause' query: SELECT count(node.nid) FROM node node LEFT JOIN content_type_property node_data_field_discount ON node.vid = node_data_field_discount.vid LEFT JOIN content_type_property node_data_field_summary ON node.vid = node_data_field_summary.vid WHERE ((n.moderate != 1)) AND ( (node.status = '1') AND (node.type IN ('property')) )

I'm using 5.x-2.4.

Could this be a Views issue?

This same issue reappeared in later versions of Drupal core. Not sure if this is a big enough issue to get a patch in, but someone working on comment should probably be aware of it.

On second look, this appears to be a new issue. The patch to 5.3 got into core and my SQL error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LEFT JOIN node n ON node.nid = n.nid WHERE ((n.moderate != 1)) LIMIT 0, 25' at line 1 query: LEFT JOIN node n ON node.nid = n.nid WHERE ((n.moderate != 1)) LIMIT 0, 25

seems to legitimately be coming from modr8.

I've tracked the problem down to the modr8_db_rewrite_sql function. Apparently it gets called in one instance when $query is an empty string, so the result tacks a where clause on to nothing, which of course, is invalid. My fix: find line 268 in modr8.module and replace

      if (!$access) {

with

      if (!$access && $query) {

No more error!
Jen

Patch attached.

hmm, weird - sounds still like maybe a core issue, but looks liek a pretty safe patch.

Committed this fix to Drupal 6.x (HEAD) and DRUPAL-5