Remove the registry

1280 deletions, 663 insertions... I love this patch. Berdir gets 2:1 high fives. This is proof that adopting PHP standards is a good thing for Drupal.

I mentioned this to merlinofchaos and he pointed out that it will mean a lot of conversions to do in views (or any other contrib module with a lot of classes) to port it to 8.x once the registry is removed.

That's got to happen at some point, but I think it makes sense to schedule the actual commit of this patch so we can warn anyone else who might attempt a port. Not sure exactly when but was thinking either August 1st or September 1st (I doubt core classes will be fully converted for another 2-3 weeks and I'm going to be mostly afk the second half of June, so really that'd either be an extra 4 weeks or 8 weeks beyond when this could otherwise get committed.

+++ b/core/modules/simpletest/simpletest.module
@@ -288,13 +288,9 @@ function simpletest_log_read($test_id, $prefix, $test_class, $during_test = FALS
+ * The list of test classes is loaded by searching the designated directory ¶
+ * for each module for files matching the PSR-0 standard. Once loaded the ¶
+ * test list is cached and stored in a static variable. ¶

trailing white-spaces

Lots of the remaining tests are in #1593058: Remove system.info's files[] entry. Adding the tag.

Closing #1598610: Convert symfony.test to PSR-0 and remove all the files[] instances in system.info. Remember to also remove the PSR-0 class loading tests in symfony.test, that wouldn't even be executed, if PSR-0 wasn't working.

#9: remove-registry-1541674-9.patch queued for re-testing.

How're we looking? I know there are still patches to be committed, just wanted to see what the test-bot had to say.

Rerolled #9 out of curiosity.

Ah, the "list can not be used in namespace" problem. I guess this depends only on #1592632: Merge List field types into Options module now.

For reference, http://drupal.org/project/issues/search/views?issue_tags=PSR-0 .

See also: #1667822: Remove caching of test classes in TestDiscovery

The patch didn't apply anymore so I re-rolled #15 which is a re-roll of #9.

This was postponed both on the List->Options issue, and on Views PSR-0. The first is done, the second is not (it was until recently blocked on plugins).

Re-postponing for now.

Views should not block this removal. Last I checked and talked to @dawehner, it was using PSR-0 tests already.

The main problem for Views and all other contributed modules was the PIFR issue #1674290: PSR-0 tests in contrib modules are not found, which has been fixed already and just needs to be deployed.

The reason I rerolled it was to see what failed, so that it can be worked on, even in the postponed state (or not). Should have made that clear.

I don't think we should postpone it on Views, but I do think we should schedule this commit to give people fair warning if there are contrib projects chasing HEAD since it's not a hard patch to get in and doesn't hold anything up. What about 31st August?

I went through some of the most used projects on Drupal.org, and it looks like only Admin Menu is affected by this. I've put up #1691418: Update tests to PSR-0 to track that. Love this to go in sooner rather than later though, as I'm sure we have some follow ups to address.

[EDIT] sun reported:

However, this should not block the registry removal. I'm fine with having no automated tests for a short period. ;)

So, it looks like the only blockers are:

• #1641694: Convert query test to PSR-0
• #1637532: [META] Convert existing tests to PSR-0

Why are we only talking about test classes?

Views is 99% done converting its test classes, but hasn't begun on the 250+ non-test classes.

Also,

$ grep -nr "^files\[\]" core
core/modules/field/tests/modules/field_test/field_test.info:5:files[] = field_test.entity.inc
core/modules/system/system.info:10:files[] = tests/registry.test
core/modules/system/tests/modules/file_test/file_test.info:6:files[] = file_test.module

Can we move the registry back over to http://drupal.org/project/registry for Drupal 8? That way, if a contrib module needs it, then it can simply depend on it until it fully moves to PSR-0. If Drupal Core doesn't need the registry, then why should it be in Drupal Core?

Sounds good to me.

Sounds good!

#1716048: Do not boot bundle classes on every request, can't release with this in.

If the Annotations patch goes in, Views is done. Then we don't have to wait until August 31st.

EDIT:
By "Views is done", I mean "Views no longer needs the registry". :)

#1683644: Use Annotations for plugin discovery is in.

#34: remove-registry-1541674-34.patch queued for re-testing.

Re-rolled against HEAD.

Aside from conflicts and shifted hunks, no change except of renumbered system update. interdiff contains everything (but the shifted + conflicting hunks are misleading).

That interdiff really isn't helpful, so here's a direct patch-to-patch diff.

This patch is great. The doc comments make complete sense for what is happening in SimpleTest, and the caches being cleared is needed. RTBC.

I would like to postpone this on #1724452: Test Annotations sandbox. Views is almost done converting his classes to plugins but we need the views testbot at this stage. When that conversion is passing tests we can merge in and we don't have to rely anymore on the registry.

Ok? Thanks :)

It's also worth noting that CTools' Export UI is not yet converted to the new plugin system and PSR-0 and it relies on the registry. While it shouldn't be a difficult conversion it'll still take a little time and might be tough to get done before Munich at this point.

I said 31st August back in July, and I'm still happy to leave it until then?

+++ b/core/modules/simpletest/simpletest.module
@@ -288,13 +288,9 @@ function simpletest_log_read($test_id, $prefix, $test_class, $during_test = FALS
+ * The list of test classes is loaded by searching the designated directory
+ * for each module for files matching the PSR-0 standard. Once loaded the
+ * test list is cached and stored in a static variable.

Wrong comment wrapping. Rerolled the patch, no commit credit, please :)

Until August 31st.

Can we announce this at g.d.o/core? This is going to impact a large number of folks IMO.

Done: http://groups.drupal.org/node/248853

1 day until scheduled commit. So, simple re-roll to catch up with HEAD and to have the test bot look at it one last time.

Re-roll looks good, bot is green. Awesome! Let's do this.

Confirmed that CTools and Views are no longer using the registry.

Rerolled for #1468328: Move file entity info, managed file, and file usage functionality into File module

#61: registry-1541674-61.patch queued for re-testing.

The fail in #62 was because I submitted it too early :)

Re-RTBCing.

I would commit this, but I'm pretty sure catch really wants to, so leaving this for him for a few hours. :)

Yes, yes I did quite want to. Committed/pushed to 8.x, thanks all!

I think http://drupal.org/node/1320394 covers this for the change notice so moving straight to fixed.

Big win! :)

Woohoo! Great work everyone.

Clean up: #1810686: Remove the remaining files[] entries