Closed (fixed)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
Taxes
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Apr 2012 at 03:08 UTC
Updated:
8 May 2012 at 19:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
wodenx commentedComment #2
longwaveThe D7 code does not divide by $tax->rate; why is that different here?
D7 patch for reference: http://drupal.org/files/issues/1155656-uc_taxes-line-item-adjustment.patch
Comment #3
wodenx commentedI think when you originally created this for uc_vat, that's the way uc_vat used it. The hook was designed to return the tax (=taxable_amount * tax_rate) -- but uc_taxes collects the whole taxable amount and applies the rate at the end, so when i re-implemented for D7, I changed the hook to return the taxable amount. Can't make that change in D6 without breaking uc_vat integration, so we need divide the tax returned from the tax-adjustment callback by the rate to get the taxable amount.
Comment #4
longwaveCommitted.