Hi,
I have a request of code addition so the apache solr views module facets work fine, this is the fix that the module needs to remove so extra slashes generated when the solr query has a path as in the case of a view in the apachesolr.module getPath function.
public function getPath($new_keywords = NULL) {
if (isset($new_keywords)) {
return $this->base_path . '/' . $new_keywords;
}
if($this->getParam('q')) {
return $this->base_path . '/' . $this->getParam('q');
}else {
return $this->base_path;
}
}
Thank you in advance.
Julian Mancera
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 1538244-13.patch | 598 bytes | pwolanin |
| #2 | apache-solr-views-1538244-comment-5886574.patch | 661 bytes | julianmancera |
Comments
Comment #1
nick_vhPlease make a patch that can be tested and reviewed
Comment #2
julianmancera commentedHere is the path Nick
Regards,
Julian Mancera
Comment #3
nick_vhComment #5
nick_vh#2: apache-solr-views-1538244-comment-5886574.patch queued for re-testing.
Comment #6
nick_vh@julianmancera Can you link to the related issue for this?
Comment #8
nick_vhComment #9
nick_vh#2: apache-solr-views-1538244-comment-5886574.patch queued for re-testing.
Comment #10
julianmancera commentedHi Nick,
I reviewed the test log and this is the error
Next exception 'PDOException' with message 'SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupaltestbotmysql.simpletest766366registry' doesn't exist' in /var/lib/drupaltestbot/sites/default/files/checkout/includes/database/database.inc:2136
Seems to be a testing enviroment related error.
Can you please confirm?
Regards,
Julian
Comment #11
nick_vhThat has been taken care of already. Was indeed drupal.org testbot. What is the issue (number) in apachesolr views so people can test this change?
Comment #12
julianmancera commentedNick,
Here is the issue.
http://drupal.org/node/1428628
Regards
Julian Mancera
Comment #13
pwolanin commentedI like elseif () better
Comment #14
pwolanin commentedupdate title to reflect actual bug
Comment #15
pwolanin commentedfixed in 7.x-1.x and 6.x-3.x