Argument#2 not an array in captcha.module line 195 [#153437]

Comment	File	Size	Author
#14	captcha.php52.patch	1.08 KB	mathieu

Comment #1

skor commented 22 June 2007 at 02:59

More info:
I don't get this error on my test site which runs PHP 4.4.2/MySQL 4.1.21
I do get it on my production site which runs PHP 5.1.4/MySQL 5.0.24

Log in or register to post comments

Comment #2

skor commented 22 June 2007 at 03:31

For now, I've downgraded my production site to 5.x-1.1.

Any significant downside to that?

Log in or register to post comments

Comment #3

leoklein commented 23 June 2007 at 10:44

Title:

Argument#2 not an array in captcha.moudle line 195

» Argument#2 not an array in captcha.module line 195

I've downgraded to 5.x-1.1 as well. Works for me (as far as I can tell).

Log in or register to post comments

Comment #4

soxofaan commented 24 June 2007 at 02:35

If you don't mind trying out patched versions have a look at http://drupal.org/node/153395 , the last version at the time of this writing is at http://drupal.org/node/153395#comment-264105

Log in or register to post comments

Comment #5

robomalo commented 25 June 2007 at 16:30

I changed line 195 from

$form = array_merge($form,$result['form']);

to

$form = array_merge($form,(array)$result['form']);

This seems to work for me. With this change, this is the first release that has worked for our site since 5.x-1.1.

Log in or register to post comments

Comment #6

robomalo commented 25 June 2007 at 16:41

I lied, sorry. I spoke way too soon. I just noticed the error was gone. The entire question is gone now. Going back to 5.x-1.1...

Log in or register to post comments

Comment #7

skor commented 25 June 2007 at 19:49

@soxofaan - I'll have a chance to try out your update later this week (possibly thurs).

It's still not clear to me if the Form Store module is required for the 5.x-2.x branch. It isn't listed as a dependancy in the .info file, but and I'm not sure what to make of this

Log in or register to post comments

Comment #8

soxofaan commented 25 June 2007 at 21:13

@soxofaan - I'll have a chance to try out your update later this week (possibly thurs).

thanks

It's still not clear to me if the Form Store module is required for the 5.x-2.x branch. It isn't listed as a dependancy in the .info file, but and I'm not sure what to make of this

form_store is not required to run the captcha module if its default captcha points (forms where a captcha should be enabled) are all you need. If you want captcha's on other forms, you need form_store and form_collect to collect these forms and add them to the captcha interface.

PS: My rewrite of captcha (http://drupal.org/node/153395#comment-264105) has no dependencies (except drupal ;) ).

Log in or register to post comments

Comment #9

skor commented 30 June 2007 at 15:14

OK, finally got my dev site updated to php5 today, and verified that the error happens with php5 (but not php4)

Should have some time to try the patch tomorrow evening.

Log in or register to post comments

Comment #10

skor commented 7 July 2007 at 02:52

OK, so after updating to php5 to get the error, I downgraded to 5.x-1.1, disabled all captcha points, then upgraded to 5.x-2.2, and re-enabled some of the default captcha points. No errors.

Then I installed the form_store module, and enabled captcha on the account registration form. No errors.

So this bug is simply the result of poor upgrade path. I think I only got it because with 5.x-1.1 I had captcha enabled for new account registrations, which is not supported in 5.x-2.2 without form_store.

Possible solutions

add support in 5.x-2.2 for all the same captcha points that 5.x-1.1 had
on 5.x-2.2 install, disable all captcha points that aren't supported without form_store
better documentation or a message to the user making it clear that form_store is required for certain captcha points that were supported in 5.x-1.1

Log in or register to post comments

Comment #11

twohills commented 8 July 2007 at 08:00

+1 here.

Captcha 5.x-2.2
Drupal 5.x-dev (2007-Jun-20)
I don't think this is an upgrade error. i deleted all captcha variables and re-enabled - still had the problem

This error disables user/password and user/registration forms, even when no captcha point is set for them!

Log in or register to post comments

Comment #12

sigfredo commented 12 July 2007 at 00:57

Hi I hope that this infrmation may help to solve the bug. I have installed Captcha module on my drupal 5.1 site, I got the error Argument#2 not an array in captcha.module line 195his error. It happened wiith PHP 5.2.2. After reviewing the posts here I have downgraded PHP to Version 4.4.7 and the captcha module begin working fine, without problems, and without doing anythisng else you can see it at http://www.transformando.info.

Log in or register to post comments

Comment #13

skor commented 12 July 2007 at 01:48

@twohills - Did you downgrade to captcha 5.x-1.1 before disabling all captchas, and then upgrading to 5.x-2.2? That worked for me. Then once you're back up to 5.x-2.2, you'll need form_store module to get captchas for user/registration and user/password.

Alternatively, you could try just installing the form_store module and see if that fixes it.
Another option (possibly 5.x-3.x) is being worked over here: http://drupal.org/node/153395

Log in or register to post comments

Comment #14

mathieu commented 18 July 2007 at 20:46

Version:	5.x-2.2	» 5.x-3.x-dev
Status:	Active	» Needs review

Status	File	Size
new	captcha.php52.patch	1.08 KB

Here's a patch that hopefully solves this bug (it does for me, with PHP 5.2). This patch is agains 5.x-3.x-dev. This is a fairly simple patch, I just hope I read this bug report correctly and that I had the same problem as everybody else.