Files: 
CommentFileSizeAuthor
#4 1533232-field-module-coder-review.diff6.95 KBGaëlG
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1533232-field-module-coder-review.diff. Unable to apply patch. See the log in the details link for more information. View
#2 drupal-code_cleanup-1533232-3.patch105.72 KB-enzo-
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal-code_cleanup-1533232-3.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

NROTC_Webmaster’s picture

Status: Active » Postponed
-enzo-’s picture

FileSize
105.72 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal-code_cleanup-1533232-3.patch. Unable to apply patch. See the log in the details link for more information. View

I don't realize this issue was posponed :S

I did a code cleanup.

I guess after the issue #1326634 will be completed, this patch needs to be re-rolled.

GaëlG’s picture

Issue summary: View changes
Status: Postponed » Needs work
Issue tags: +#amsterdam2014

I'm having a try with this.

GaëlG’s picture

Issue tags: -#amsterdam2014
FileSize
6.95 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1533232-field-module-coder-review.diff. Unable to apply patch. See the log in the details link for more information. View

Well, this might not be the best thing to do during a DC sprint. The code moves too much! Anyway, here's a little diff of what I did. More info on encountered problems in the parent meta issue.

yannisc’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 1533232-field-module-coder-review.diff, failed testing.

The last submitted patch, 2: drupal-code_cleanup-1533232-3.patch, failed testing.

xjm’s picture

Version: 8.0.x-dev » 8.1.x-dev
Priority: Normal » Minor
Status: Needs work » Postponed
Issue tags: -Novice

Thanks for all the work here so far. See #1518116-86: [meta] Make Core pass Coder Review. This issue is postponed until the meta issue is either closed or reopened.

pfrenssen’s picture

Status: Postponed » Closed (duplicate)

Closing in favor of #2571965: [meta] Fix coding standards in core. In this issue the coding standards will be fixed on a sniff-per-sniff basis rather than a module-per-module basis.