Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | comment-psr-1533020-10.patch | 30.64 KB | duellj |
#4 | comment-psr-1533020-4.patch | 28.41 KB | duellj |
#2 | comment-psr-1533020-2.patch | 27.81 KB | duellj |
Comments
Comment #1
BerdirAdding tag
Comment #2
duellj CreditAttribution: duellj commentedOk, here's the first attempt at converting Comment and CommentStorageController to PSR-0. Also changed all docblock references to Comment to the fully qualified name.
Comment #3
aspilicious CreditAttribution: aspilicious commentedAre these all the instances of "Comment" in core?
Comment #4
duellj CreditAttribution: duellj commentedGood question, did another pass and I missed a couple of docblock updates in comment.test. But other than that I think I caught all instances of "Comment" in core
Comment #5
RobLoach#4: comment-psr-1533020-4.patch queued for re-testing.
Comment #6
xjmWe should also add information about this conversion to the original change notification at
http://drupal.org/node/1400186http://drupal.org/node/1479568 once it is ready.Comment #7
aspilicious CreditAttribution: aspilicious commentedIf I'm correct, we should use the full namespace path in api.php files. That way we can easily copy paste example code if needed:
should be
Look at http://drupal.org/node/1353118 for more info
Example: http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/modul...
Comment #8
Berdir#4: comment-psr-1533020-4.patch queued for re-testing.
Comment #10
duellj CreditAttribution: duellj commentedRerolled patch and updated api docs to include full namespaces (from #7).
Comment #11
aspilicious CreditAttribution: aspilicious commentedLooks good.
Comment #12
catchThanks! Committed/pushed to 8.x.
Comment #13
aspilicious CreditAttribution: aspilicious commentedI added this to http://drupal.org/node/1400186
Comment #14
BerdirLooks good. @xjm also mentioned http://drupal.org/node/1479568, but I have no clue how to add it there. The only thing that has been converted is the CommentController class.
Comment #15
aspilicious CreditAttribution: aspilicious commentedWe have a subsystem => namespace table.
What if we add a module => namespace table under it?
Comment #16
Berdirand list what there? That comment.module is now Drupal\comment? That's kinda obvious and can be listed in a single sentence for all modules, no?
For it to make sense, we'd need to actually list single classes there. Which would be possible because there aren't that many non-test classes in modules that already existed in 7.x.
Comment #17
xjmI think just in the entity one was fine. Someone convinced me it should go in the PSR-0 one, but I think so long as we just make sure the issue is referenced on both, what Berdir and aspilicious have already added is quite clear.
Comment #18
aspilicious CreditAttribution: aspilicious commentedOk references are added. Ow yeah! Marking this fixed!
Comment #19
Tor Arne Thune CreditAttribution: Tor Arne Thune commented