7.x-1.x has a lot of tests now.

I've started a backport to 6.x-2.x to be able to run them on d.o as well.

I discovered at least one serious issue related to the recent taxonomy term change that causes the newsletter category selection to completely break as it tries to store the whole term object to the database.

Will try to post a patch soon.

Note that this is by far not a complete backport as this would also include all of the new features added to 7.x-1.x. Just a bare minimum to get the tests actually working and also unblock other modules from using Testbot on 6.x, for example simplenews_scheduler: http://qa.drupal.org/pifr/test/254554

Comments

berdir’s picture

Status: Active » Needs review
StatusFileSize
new67 KB

Uh, that was a ride! ;)

The attached patch contains a backport of the 7.x-1.x, thrown out everything that wasn't applicable, fixed what was broken, among other things does this fix tons of notices all over the place (including, but not limited to #1466424: php 5.3 notices and also the broken subscribe form validation (based on #1461356: Subscribe form validation not working but fixed so that it actually works both for anon and auth users).

Patch is huge, but I will go ahead and commit this one soon. This should enable automated testing of patches in the 6.x-2.x queue and is certainly better than what we currently have.

berdir’s picture

Status: Needs review » Fixed

Commited as that is the only way to get the testbot execute the tests because the branch tests are broken.

=> 6.x-2.x tests are green: http://qa.drupal.org/pifr/test/198463 !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.