I'm not really sure it should require curl at all, since drupal_http_request is available in core (and thus on any Drupal installation). But since I don't know the limitations of drupal_http_request and don't have the time to check what DrupalOAuthClient is doing with curl, I'm providing a patch to warn new users that curl is a requirement for oauth_common.

CommentFileSizeAuthor
#1 1529166-oauth-adding-curl-to-hook-requirements.patch1.24 KBbarraponto

Comments

barraponto’s picture

barraponto
he / him
commented
Status: Active » Needs review
StatusFileSize
new 1529166-oauth-adding-curl-to-hook-requirements.patch1.24 KB

Borrowed code heavily from http://drupalcontrib.org/api/drupal/contributions%21ubercart%21payment%2...

juampynr’s picture

juampynr commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Needs work

Committed. I have changed slightly the wording though to make it clear that it is a dependency of the OAuth module.

http://drupalcode.org/project/oauth.git/commitdiff/8e2d9d8

This needs a patch for branch 6.x-3.x.

Thanks!

juampynr’s picture

juampynr commented
Status: Needs work » Fixed

Backported to 6.x-3.x. I uninstalled PHP's cURL library and verified that the correct error was generated alerting about the missing dependency.

http://drupalcode.org/project/oauth.git/commitdiff/f23b9b1af717e3d9715df...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.