Template suggestion names incorrect for some Panels layouts

OK, for now I am kinda hacking my way around this by looking in the suggestions array in hook_process_node() and listening for a match, if so something like this:

 if (in_array('two_50', $vars['theme_hook_suggestions'])) {
      $vars['ds_prefix'] = '<article class="' . $vars['classes'] . '">';
      $vars['ds_suffix'] = '</article>';
  }

So I have some empty variables for printing markup in the actual plugin template, could come in handy actually, I can initialize them via the plugins own preprocess function when not being used by DS (the coming in handy bit, maybe useful for panelizer or other etc).

I think this will do for now, unless we can fix that issue, at least I can ship the theme with my panels layouts auto-magically wrapping the planels plugin template in the right markup when being used by DS, which BTW is HTML5 and is required to keep the semantic structure of the page intelligible to machines and why I am being a bit anal about this ;)

I hope my ramblings are making some sense.

In the end, to save users of Adaptivetheme a wtf moment when their template suggestions fail to take I have implimented my ideas in #1 so now any node that uses a Panel layout through Display Suite (a Panels plugin layout supplied by Adaptivetheme core) will automagically get wrapped in article elements with the node id, classes and attributes.

I really do think this is a bug after all, although I can concede its one we may have to live with and simply provide such workarounds and document it.

My workaround is a wee bit of a hack but it works, and I can't see another way of detecting if we're looking at a display suite rendered node.

In my code below responsive_panels_plugin_names() returns a list of Panels layout names supplied by Adaptivetheme or any of its sub-themes, if themers want to do something like this in their theme they could hard code such a list like in #1, this code runs in hook_process_node(). It requires additional variables to print inside the panel plugin template, namely $panel_prefix and $panel_suffix, and these must be initialized or checked etc.

  // If a panels layout is being used by Display Suite in a node, we wrap the
  // the layout in markup to make the themers life a little easier and remove
  // the requirement to add a DS template override.
  if (module_exists('ds')) {
    $panels_data = drupal_static(__FUNCTION__, array());
    if (empty($panels_data)) {
      $panels_data = responsive_panels_plugin_names();
    }
    foreach ($panels_data as $plugin => $name) {
      if (in_array($name, $vars['theme_hook_suggestions'])) {
        $vars['panel_prefix'] = '<article id="node-' . $vars['node']->nid . '" class="' . $vars['classes'] . ' clearfix"' . $vars['attributes'] . '>';
        $vars['panel_suffix'] = '</article>';
      }
    }
  }

Yup, that's the shit swentel, working perfectly here, and yes the icons are a nice touch!

$vars['rendered_by_ds'] does me a lot of favors and will be very useful I am sure.

The whole new version/improvements you guys have done over the past days are fantastic, I mean it was good before, now awesome-er.