Hello,

UC_quote module calls uc_quote_action_get_quote() function and passes three arguments, even though the function accepts only two. That function does not use the third variable at all.

There is no error, but the last argument ($user) should be removed to avoid confusion.

File: ubercart/shipping/uc_quote/uc_quote.module
Line 918

This:
$quote_data = uc_quote_action_get_quote($arg1, $method, $user);

Should be changed to:
$quote_data = uc_quote_action_get_quote($arg1, $method);

Thanks!

CommentFileSizeAuthor
#2 1513902-uc_quote-unused-var.patch1.73 KBlongwave

Comments

longwave’s picture

Status: Fixed » Active
longwave’s picture

Version: 6.x-2.7 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new1.73 KB

This function was called with the unused third parameter in three places.

longwave’s picture

Status: Needs review » Fixed

Committed #2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.