After upgrading from D5 to D7 our node/add/simplenews listed the wrong taxonomy

Next step is to get back the Simplenews tab on node/%node/simplenews

This is resolved by visiting admin/structure/types/manage/simplenews
Now check the 'Use as simplenews newsletter' on the 'Publishing options' 'tab'

I think this is an upgrade _bug_ now.

Scanning the 6.x-2.x code it uses simplenews_content_types where 7.x-1.x uses simplenews_content_type_NODETYPE

simplenews.install is not checking for values of both mentioned variables to update D6 settings.

The only occurrence is when _installing_ simplenews

function _simplenews_install_nodetype() {
  // Create a newsletter type if needed.
  $type = node_type_get_type('simplenews');

...
  if (!field_info_instance('node', 'field_simplenews_term', $type->type)) {
    simplenews_add_term_field($type);
  }
  variable_set('simplenews_content_type_' . $type->type, TRUE);
}

I expected a call to this function in

function simplenews_update_7000() {}

so promote this now to a bug.

After the customer fixed the above we now ran into "Illegal Choice has been detected"

- #999814: An illegal choice has been detected. Please contact the site administrator.
- #989742: Illegal choice 7
- #1356864: SimpleNews error: An illegal choice has been detected. Please contact the site administrator

Suggests a solution by berdir which is a little abracadabra to me :(

Make sure that you haven't enabled the Newsletter category field in the manage display forms for the corresponding content type.

Checking the field settings I noticed we have TWO category fields. One from the upgrade and another from ?

My guess now is the upgrade transformed the simplenews category to an 'detached' state for simplenews which created a new field without proper settings.

What do you think?

When checking the 'weird version' it is attached to the wrong category which seemed to be empty.

On irc berdir explained the second taxonomy term field 'field_simplenews_term' was added by checking the content type was a simplenews type. Thus that lead to a duplication of taxonomy fields.

After configuring the added taxonomy field correctly I was able to send a newsletter.

We now should delete the 'old' taxonomy as simplenews relies on the machine readable name being 'field_simplenews_term'.

But I guess old news issues need to get the term set correctly first. ... to be continued ...