I just started using Workflow 7.x=1.0 and it's fabulous. Thank you SOOOO much!

I did notice as I was building a panel for a form that the form element to edit the workflow was not available in Panels. Is this a known issue?

Comments

Patribus’s picture

I'm also very interesed in having workflow fields available in panels!

Patribus’s picture

still no reaction? :-(

man, i need this feature so much!

cheers

videographics’s picture

Of course I agree but go easy... It looks like Bastlynn is the only one doing anything with this module at the moment. I expect she'll need some help if the queue is going to get more attention any quicker than it is.

Realistically, for now, I'm just grateful we have a port of this for 7. For a while there I was getting a bit worried we'd never see it. It's a big part of a lot of my site workflows.

Francis47’s picture

This issue can be resolved by inserting the "General Form" - It has the help text: "Everything in the form that is not displayed by other content."

Its far from optimal to have the Workflow form grouped along with "Everything in the form that is not displayed by other content.", but its better than not having the Workflow form - My humble opinion.

I'll look forward to a solution and live with the above until then.

videographics’s picture

francis47, yes, that IS the current workaround but, as you say, it's far from optimal. Thanks for pointing that out to those who might not know that.

To clarify... The intention of this post is to identify a need for independent control over the Workflow form elements within Panels.

joel_osc’s picture

Status: Active » Needs review
StatusFileSize
new1.87 KB

Here is a patch which adds this functionality, seems to work for me so we'll let the community try it. Cheers.

socialnicheguru’s picture

which file does this patch too

joel_osc’s picture

The patch creates new files which define the ctools plugin. FYI - there is likely a bit more work to be done on this patch to add a 'view state' widget, but I have not had time to write it yet. I just used views (content pane) for the time being.

nancydru’s picture

So, is this "Needs review" or "Needs work?"

nancydru’s picture

Status: Needs review » Needs work

"Cannot apply binary patch to 'plugins/content/types/icon_node_form.png' without full index line"

joel_osc’s picture

StatusFileSize
new2.88 KB

Sorry for the delay, this one fell off the radar a bit. Here is a patch rolled against the latest dev version.

joel_osc’s picture

Status: Needs work » Needs review

Setting status to needs review. Input also welcome.

nancydru’s picture

Thanks for the patch. How can I test this?

joel_osc’s picture

Your welcome! Sorry, I should have included the steps to test this before.

To test:

0. enable panels, ctools, page manager and of course workflow with the patch
1. enable the 'node_edit' override in page manager (admin/structure/pages)
2. edit the 'node_edit' override
3. you may need to create a variant or edit the one that is there already
4. under 'content' select one of the gears in a region and choose 'Add content'
5. under the 'Form content' tab there should be an element called 'workflow', select it and save it to the form.
6. now edit a node with workflow enabled and you should see the workflow state selector in the region where you added it

if you want to use a distro with all the ctools, panels, etc. set-up already you can use this one: http://drupal.org/project/wet - it is a cool one that we have worked with the Government of Canada on building.

I should note that it already possible to add the workflow form to the node edit page override without this module, however it is a bit awkward from a usability perspective because there is an update button on the edit form. Rather than do form_alters to remove the update button I thought it might be easier to add this small plugin.

Cheers.

nancydru’s picture

nancydru’s picture

Status: Needs review » Needs work

The patch failed while searching for workflow_insert_workflow_node_history($data)

djake’s picture

Any progress on this? Would be a huge help.

joel_osc’s picture

I didn' really undestand the error mentioned above, so I have not looked into it much. I am using the patch on a few sites already and I am not having any issues. I just re-tested applying the patch so that seems to work, perhaps the error above was at run-time then? Maybe you could give it a try and see if you get any errors - I would be happy to look into them if you do.

nancydru’s picture

What release did you test applying the patch? When I tried it on the dev that was current then, it failed to apply.

joel_osc’s picture

Status: Needs work » Needs review
StatusFileSize
new2.27 KB

I had tested against the 1.2 release, noticed some whitespace errors so have re-rolled the patch against the latest dev release. Please let me know if this one still has issues, thanks!

johnv’s picture

Issue summary: View changes
Status: Needs review » Needs work

I'm not familiar with Panels, but the new 2.x version probably needs a rework/test of this patch.

natew’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new2.34 KB

I re-packaged joel_osc patch for the latest 7.x-2.x-dev and it is working for me.

botris’s picture

Please change return 'plugins/content_types'; into return "plugins/$plugin"; so to be compatible with #2187731: Panels access / selection rules based on workflow and with other ctool plugins in general. Thanks.

joel_osc’s picture

StatusFileSize
new2.33 KB

With workflow fields this patch is no longer necessary as fields are natively supported in panels. If anyone using workflow node needs the patch here it is with changes as suggested. I am not sure if it is worth adding to the workflow module at this point.

johnv’s picture

Title: Better integration with panels » Better integration of workflow_node with panels
Component: Code » Workflow Node API
Issue summary: View changes
bibishani’s picture

StatusFileSize
new2.5 KB

I`m adding re-packaged joel_osc patch for the latest 7.x-2.x-dev with hash : 9d5f81dd67e69c88f7966f9be0f1cbd405e2372c from 2014-May-13 .

johnv’s picture

If the hook in workflow.module is moved to workflownode.module and it still works, i can add it to the module.

johnv’s picture

Status: Needs review » Needs work

  • Commit 9e8587c on 7.x-2.x authored by joel_osc, committed by johnv:
    Issue #1511694 by joel_osc: Added integration of WorkflowNode with...
johnv’s picture

Version: 7.x-2.x-dev » 7.x-2.4-beta2
Status: Needs work » Fixed

Committed this with attribution , @joel_osc.

It was committed to workflow_node not workflow. I hope this does not make a difference.
Please reopen if there is a problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dshields’s picture

Version: 7.x-2.4-beta2 » 7.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new550 bytes

This actually doesn't seem to work anymore. I'm not sure if something in Chaos Tools changed or if there's another culprit, but this seems to only work now when you explicitly state the render callback for the plugin. Test this patch against the latest dev (7.x-2.5+15-dev) and let me know if this works now.

Renee S’s picture

There is a problem with the workflow_field implementation in Panels too, at least if you're using action buttons -- the formatter it uses is the default formatter, not a selection formatter, but the action button formatter doesn't, of course, work there.

ETA: Since this is set as workflow_node, I've created this as a new issue here: #2487728: Panels not compatible with workflow_field-with-action-buttons

  • johnv committed afba005 on 7.x-2.x authored by dshields
    Issue #1511694 by joel_osc, bibishani, natew, dshields: Better...
johnv’s picture

Version: 7.x-2.x-dev » 7.x-2.5
Status: Needs review » Fixed

Let's close this one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.