This is step 0 for #1499460: [meta] New theme system

CommentFileSizeAuthor
#1 1499464.patch674 byteschx

Comments

chx’s picture

chx commented
Status: Active » Needs review
StatusFileSize
new 1499464.patch674 bytes
chx’s picture

chx commented

Obviously later we want context injected. But this is a great start IMO.

alansaviolobo queued 1: 1499464.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 1499464.patch, failed testing.

alansaviolobo’s picture

alansaviolobo commented
Issue summary: View changes
Issue tags: +Needs reroll
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

- Is this still relevant after the move to Twig?
- Should this be changed to support for tokens in Twig?

Just rerolling the original patch seems pointless at the moment, since this would require a fair number of tests before this could be implemented too. So this would need much more work then just a reroll.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: -Needs reroll

As one of the theme system maintainers this is a won't fix from me. At the very least should be postponed IMO.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Yup we have Twig, so this can be closed.