I did some modifications to make the Tab Menu appear on the right side of the header. It's not working that well with the responsive nature of the theme.
I'm going to spend some time fixing it, and wanted to contribute it to the project.
How would you like me to add contribute? Optional CSS that is commented out? Or should this go in FooTheme? Or should I not worry about submitting a patch?
Here is my site:
http://www.bioworldusa.com
Comments
Comment #1
Jeff Burnz commentedI actually have a set of theme settings that do this, but they are not in any of the themes as yet - I know its rather complicated to work with the responsiveness of the themes and requires quite a bit of CSS juggling in media queries to make it work properly.
If I were to take a patch for this it would have to be configurable, as in a theme setting, and has to have a sensible default for each breakpoint, whether that means being center aligned in small screens or whatever etc.
I am happy to share my code with you if you want to leverage it, its just basic form stuff and a bit of CSS.
Comment #2
philbar commentedYes please!
Comment #3
Jeff Burnz commentedActually, I totally forgot about this, but this setting is in Pixture Reloaded, lol.
Here it is, slightly modified to work with Sky:
Form:
This is going to slot in around line 567 in Sky's
theme-settings.phpfile. The new settings will be under "Menu bullets" in Skys Appearance settings UI, so you might want to change the name of that vertical tab.Body class:
As per most settings this uses a body class. in Sky's
template.php, around line 32 you'll find the$settings array(), add one item to that array, being the theme setting:'menu_bar_position',Default setting:
Now you can skip this but if you want to migrate your site you should add the default setting to the info file:
settings[menu_bar_position] = 'mbp-l'CSS:
This can go anywhere, probably at the bottom of
sky.settings.style.cssis a good place.Comment #4
Jeff Burnz commentedAnd the media query, forgot about it, looks like in Pixture reloaded I only bother pushing something at IE6/7 for this, which works since these themes use respond.js
Comment #5
philbar commentedI see you already committed these changes:
http://drupal.org/commitlog/commit/4222/94642a072ee0992851370125c333cad5...
http://drupal.org/commitlog/commit/4222/b6e8b1004a4c837304fa3a0e99f31570...
Is there anything I can help with, beside testing?
Comment #6
philbar commentedThere appears to be bugs in the lower resolution.
Comment #7
Jeff Burnz commentedProbably, the basic idea is that they should stack and stretch to 100% the width, so there is probably some CSS in PR that does that already that I missed.
If you can clean up that iPhone view, get them to stretch, probably a float none, display block width 100% sort of thing etc, well that would be really grand. I am so flat out trying to get 7.x-3.x in alpha ready state.
Comment #8
philbar commentedPatch for fixing smartphone resolution alignment.
Comment #9
Jeff Burnz commentedThanks a lot, I have committed with attribution!