Custom search pages are now exportable (great work!). However, when you enable a feature that includes an exported search page, the path for that page is broken.

This happens because the list of available search pages relies on a database query, but feature-based search pages do not live in the database.

CommentFileSizeAuthor
#11 1498490-11.patch3.96 KBnick_vh
#5 1498490-4.patch8.23 KBnick_vh
#3 1498490-3.patch5.83 KBnick_vh
#1 1498490-1-menu-paths-for-exported-search-pages.patch1.46 KBmilesw

Comments

milesw’s picture

milesw commented
Status: Active » Needs review
StatusFileSize
new 1498490-1-menu-paths-for-exported-search-pages.patch1.46 KB

Turns out it's a simple fix. Replaced the database query in apachesolr_search_menu_alter() with apachesolr_search_load_all_search_pages().

Status: Needs review » Needs work

The last submitted patch, 1498490-1-menu-paths-for-exported-search-pages.patch, failed testing.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs work » Needs review
StatusFileSize
new 1498490-3.patch5.83 KB

This should be better

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

This patch allows reverting search pages to their in-code variant.

https://skitch.com/nick_vh/8qdas/apache-solr-search-smartphone-compare

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1498490-4.patch8.23 KB

Forgot to attach it!

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Patch (to be ported)

Committed

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
milesw’s picture

milesw commented

Excellent, thanks Nick. It's great having pages and environments exportable.

phoenix’s picture

phoenix commented

Great news Nick. We had the same problem here. Will try it out.
Just saw you changed t he version to drupal 6. Is it also fixed in the drupal 7 version?

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

It has been committed to 7.x-1.x, needs a backport for the 6.x-3.x version :-)

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1498490-11.patch3.96 KB
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Patch (to be ported) » Closed (fixed)

Fixed for all