Problem / Motivation

Make the new HTML <input type="week" .../> element available as an FAPI element in core.

References

http://www.w3.org/TR/html-markup/input.week.html

CommentFileSizeAuthor
#39 1496686-39.patch6.3 KBrpayanm
#37 941266-37.patch7.98 KBrpayanm
#35 week-element-1496686-35.patch62.4 KBSharique
#33 week-element-1496686-33.patch62.06 KBSharique
#30 week-element-1496686-30.patch62.04 KBSharique
#25 week-element-1496686-25.patch104.06 KBsiva_epari
#15 1496686-week-element-13.patch3.3 KBvijaycs85
#11 1496686-week-element-11.patch3.3 KBJalandhar
#9 1496686-week-element-9.patch3.27 KBmgifford
#4 1496686-week-element-3.patch3.25 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hansyg’s picture

hansyg CreditAttribution: hansyg commented
Issue tags: +html5

taggin

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

See #675348-64: META: Support HTML5 form input elements

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue summary: View changes
Parent issue: » #675348: META: Support HTML5 form input elements
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
Parent issue: #675348: META: Support HTML5 form input elements »
FileSize
1496686-week-element-3.patch3.25 KB

Initial patch...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Parent issue: » #675348: META: Support HTML5 form input elements
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Nice! I was hoping it might be that easy. Thanks...

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

4: 1496686-week-element-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 1496686-week-element-3.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs work » Needs review
FileSize
1496686-week-element-9.patch3.27 KB

reroll

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
Jalandhar’s picture

Jalandhar CreditAttribution: Jalandhar commented
Status: Needs work » Needs review
FileSize
1496686-week-element-11.patch3.3 KB

Here is the rerolled patch.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Related issues: +#1496682: Add new HTML5 FAPI Element : month, +#1496652: Add new HTML5 FAPI Element : datetime-local

So to confirm, there are no UI changes with this. It's simply a matter of being able to use a #week form element when building custom forms. We might extend the UI in the future, but there's nothing here to show yet, right?

So to test this we need to simply work to verify the code is good and that we can build form with type <input type="weak" />.

Which is presumably what we also need to do for #1496682: Add new HTML5 FAPI Element : month & #1496652: Add new HTML5 FAPI Element : datetime-local

Would be interesting to have a combined patch for these three issues as they are so related... Not sure if that would help get it into Core though.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue tags: -Needs reroll

here is a reroll of #11.

Would be interesting to have a combined patch for these three issues as they are so related...

let's get them in at once, combining in to one patch may need further patch/review/commit credit into account.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

is it attached?

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
1496686-week-element-13.patch3.3 KB

:) here it is for real...

Jalandhar’s picture

Jalandhar CreditAttribution: Jalandhar commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch #15, Needs reroll.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Issue tags: +DUGBE1409

Working on this @ DUG Belgium.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Issue tags: -DUGBE1409
thtas’s picture

thtas CreditAttribution: thtas commented
Assigned: Unassigned » thtas
thtas’s picture

thtas CreditAttribution: thtas commented
Assigned: thtas » Unassigned
jonathan_hunt’s picture

jonathan_hunt CreditAttribution: jonathan_hunt commented
Issue summary: View changes

w3.org 404'ed, so new link provided.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

@jonathan_hunt I think we should close this issue. I think that the week element has been removed from HTML5 http://stackoverflow.com/questions/21263515/why-is-html5-input-type-date...

jonathan_hunt’s picture

jonathan_hunt CreditAttribution: jonathan_hunt commented

@mgifford The link I offered turns out to be a discontinued document (http://www.w3.org/TR/html-markup/Overview.html). The current editor's draft for HTML5 is at http://drafts.htmlwg.org/html/master/ and includes http://www.w3.org/html/wg/drafts/html/master/semantics.html#week-state-(type=week) so the issue is still valid.

siva_epari’s picture

siva_epari CreditAttribution: siva_epari commented
Assigned: Unassigned » siva_epari
siva_epari’s picture

siva_epari CreditAttribution: siva_epari commented
Status: Needs work » Needs review
Issue tags: -Needs reroll +#drupalgoa2015
FileSize
week-element-1496686-25.patch104.06 KB

Patch rerolled.

siva_epari’s picture

siva_epari CreditAttribution: siva_epari commented
Assigned: siva_epari » Unassigned

Status: Needs review » Needs work

The last submitted patch, 25: week-element-1496686-25.patch, failed testing.

siva_epari’s picture

siva_epari CreditAttribution: siva_epari commented
Assigned: Unassigned » siva_epari
siva_epari’s picture

siva_epari CreditAttribution: siva_epari commented
Issue tags: +Needs reroll
Sharique’s picture

Sharique CreditAttribution: Sharique commented
Status: Needs work » Needs review
FileSize
week-element-1496686-30.patch62.04 KB

Status: Needs review » Needs work

The last submitted patch, 30: week-element-1496686-30.patch, failed testing.

siva_epari’s picture

siva_epari CreditAttribution: siva_epari commented
Assigned: siva_epari » Unassigned
Sharique’s picture

Sharique CreditAttribution: Sharique commented
Status: Needs work » Needs review
FileSize
week-element-1496686-33.patch62.06 KB

Status: Needs review » Needs work

The last submitted patch, 33: week-element-1496686-33.patch, failed testing.

Sharique’s picture

Sharique CreditAttribution: Sharique commented
Status: Needs work » Needs review
FileSize
week-element-1496686-35.patch62.4 KB

Status: Needs review » Needs work

The last submitted patch, 35: week-element-1496686-35.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
FileSize
941266-37.patch7.98 KB

Please review.

Status: Needs review » Needs work

The last submitted patch, 37: 941266-37.patch, failed testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm at SeeD EM commented
Status: Needs work » Needs review
FileSize
1496686-39.patch6.3 KB

Uppss wrong patch...

dcam’s picture

dcam CreditAttribution: dcam commented
Issue tags: -Needs reroll

#39 still applies. Removing the "Needs reroll" tag in preparation for Drupalcon Los Angeles sprints.

Jalandhar’s picture

Jalandhar CreditAttribution: Jalandhar commented
Status: Needs review » Needs work

This needs to be rerolled.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Version: 8.0.x-dev » 8.1.x-dev

Since this is a feature request, I don't think we can do this during the beta evalutaion. So postponing for 8.1.x.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.