Strict warning: Only variables should be passed by reference in panels_breadcrumbs_ctools_render_alter() [#1495618]

Strict warning: Only variables should be passed by reference in panels_breadcrumbs_ctools_render_alter() (line 164 of /opt/development/yourhelps/sites/all/modules/panels_breadcrumbs/panels_breadcrumbs.module).

Comment	File	Size	Author
#3	panels_breadcrumbs-strict_byref_fix-1495618-3.patch	551 bytes	techninja
#1	1495618-1.patch	667 bytes	rogical
	Screenshot at 2012-03-23 15:18:34.png	13.22 KB	rogical

Comments

Comment #1

rogical commented 23 March 2012 at 07:22

Status:

Active

» Needs review

Status	File	Size
new	1495618-1.patch	667 bytes

Comment #2

devuo commented 24 March 2012 at 11:56

Status:

Needs review

» Postponed (maintainer needs more info)

Can you tell me your Breadcrumb configuration?

Comment #3

techninja commented 10 April 2012 at 01:33

Assigned:	rogical	» Unassigned
Status:	Postponed (maintainer needs more info)	» Needs review

Status	File	Size
new	panels_breadcrumbs-strict_byref_fix-1495618-3.patch	551 bytes

I've also got this problem (I run in e-strict to catch little things like this, they're not killer, but good practice). Really, all PHP wants to say is that you just can't pass the output of end() through drupal_alter, as it's by reference, you'd never be able to change the input because it's not a variable.

Even if you'd never be using it (and I admit it's silly and yet another line of code), passing an actual variable along is the only correct method. See attached patch.