in feeds.module it turns off E_DEPRECATED errors, with this comment

// We can safely use E_DEPRECATED since Drupal 7 requires PHP 5.3+

er, no it doesn't - from http://drupal.org/requirements

Drupal 7: 5.2.5 or higher (5.3 recommended)

CommentFileSizeAuthor
#5 feeds-deprecated-1485870-5.patch2.02 KBtwistor
#2 feeds-deprecated-1485870-2.patch1.37 KBbrad.bulger
#1 feeds-deprecated-1485870-1.patch1.37 KBbrad.bulger
feeds.php53.patch754 bytesbrad.bulger

Comments

brad.bulger’s picture

brad.bulger commented
StatusFileSize
new feeds-deprecated-1485870-1.patch1.37 KB

rebuilt patch against current version. the constant is referenced in two places, both related to SimplePie, so maybe there's a central place to define it if undefined, rather than testing for it.

brad.bulger’s picture

brad.bulger commented
StatusFileSize
new feeds-deprecated-1485870-2.patch1.37 KB

sorry, whitespace error

simon georges’s picture

simon georges commented
Status: Active » Needs review

Changing status, as there is a patch.

twistor’s picture

twistor commented
Title: check for existence of E_DEPRECATED before using it » Remove custom error reporting for SimplePie.
Assigned: Unassigned » twistor
Category: Bug report » Task
Issue summary: View changes
Status: Needs review » Needs work

Better yet, let's just rip out all of that code.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds-deprecated-1485870-5.patch2.02 KB

Let's see.

twistor’s picture

twistor commented
Assigned: twistor » Unassigned
Status: Needs review » Fixed

http://drupalcode.org/project/feeds.git/commit/ed6cfa8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.