in feeds.module it turns off E_DEPRECATED errors, with this comment

// We can safely use E_DEPRECATED since Drupal 7 requires PHP 5.3+

er, no it doesn't - from http://drupal.org/requirements

Drupal 7: 5.2.5 or higher (5.3 recommended)

CommentFileSizeAuthor
#5 feeds-deprecated-1485870-5.patch2.02 KBtwistor
PASSED: [[SimpleTest]]: [MySQL] 4,787 pass(es). View
#2 feeds-deprecated-1485870-2.patch1.37 KBbrad.bulger
#1 feeds-deprecated-1485870-1.patch1.37 KBbrad.bulger
feeds.php53.patch754 bytesbrad.bulger
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

brad.bulger’s picture

rebuilt patch against current version. the constant is referenced in two places, both related to SimplePie, so maybe there's a central place to define it if undefined, rather than testing for it.

brad.bulger’s picture

sorry, whitespace error

Simon Georges’s picture

Status: Active » Needs review

Changing status, as there is a patch.

twistor’s picture

Title: check for existence of E_DEPRECATED before using it » Remove custom error reporting for SimplePie.
Assigned: Unassigned » twistor
Category: Bug report » Task
Issue summary: View changes
Status: Needs review » Needs work

Better yet, let's just rip out all of that code.

twistor’s picture

Status: Needs work » Needs review
FileSize
2.02 KB
PASSED: [[SimpleTest]]: [MySQL] 4,787 pass(es). View

Let's see.

twistor’s picture

Assigned: twistor » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.