Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Forum_block contains hardcoded HTML that is not passed trough the theme layer.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | theme_more_link0.patch | 4.94 KB | floretan |
| #1 | forum.module0.patch | 1.64 KB | floretan |
Comments
Comment #1
floretan CreditAttribution: floretan commentedHere's a patch that creates a template file forum-block.tpl.php and replaces the hard-coded html in forum_block by a call to theme('forum-block', $content).
Comment #2
floretan CreditAttribution: floretan commentedsorry, I just realized some issues with my patch. I need to do more work on it, please ignore it for now.
Comment #3
floretan CreditAttribution: floretan commentedThis patch replaces the hardcoded HTML for the "more" link on blocks with a theme function.
The bug was originally reported for the forum block, but this patch fixes the same issue for the aggregator and blog blocks as well.
The patch has been tested with all modified blocks.
Comment #4
floretan CreditAttribution: floretan commentedComment #5
dmitrig01 CreditAttribution: dmitrig01 commentedComment #6
Gábor HojtsyI was thinking about whether using l() in the theme function would be better, but now that we already have the url(), this seemed like overkill. And we are already in a theme function. So committed the patch as-is. Thanks.
Comment #7
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.