If there are no OpenID identities in user/%uid/openid page, it shows plain table header with no content inside table. According to http://drupal.org/node/604342 and #504428: Roll-out 'Empty text' pattern to other admin pages. empty table should contain an explanation and/or call to action.

Proposed wording if there is no content in the table:

No OpenID identities available.
Files: 
CommentFileSizeAuthor
#6 openid_empty_pattern-D7-1473214-6.patch486 bytesroborn
PASSED: [[SimpleTest]]: [MySQL] 39,375 pass(es).
[ View ]
#3 openid_empty_pattern-D8-1473214-2.patch506 bytesnmudgal
PASSED: [[SimpleTest]]: [MySQL] 35,647 pass(es).
[ View ]
#1 drupal-openid-empty-pattern-1473214-2.patch489 byteskika
PASSED: [[SimpleTest]]: [MySQL] 35,147 pass(es).
[ View ]
empty_openid_user.png78.86 KBkika

Comments

kika’s picture

Status:Active» Needs review
StatusFileSize
new489 bytes
PASSED: [[SimpleTest]]: [MySQL] 35,147 pass(es).
[ View ]

Here's the patch.

c960657’s picture

+    '#empty' => t('No OpenID identities available.'),

I wonder if “available” is the best word to use in this context. How about 'No OpenID identities for this account'?

nmudgal’s picture

StatusFileSize
new506 bytes
PASSED: [[SimpleTest]]: [MySQL] 35,647 pass(es).
[ View ]

I merged both #1, #2 & here is proposed wordings:
No OpenID identities available for this account.
Patch attached.

Thanks.

roborn’s picture

Status:Needs review» Reviewed & tested by the community

Yes, sounds good.
The patch applies cleanly and works as expected. RTBC.

webchick’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)
Issue tags:+needs backport to D7

Awesome! Thanks a lot for this nice little improvement.

Committed and pushed to 8.x. I think we need this patch in 7.x. as well?

roborn’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new486 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,375 pass(es).
[ View ]

Agree :)
Here's the patch for D7

Devin Carlson’s picture

Status:Needs review» Reviewed & tested by the community

The patch in #6 applied cleanly and added the empty text to the "OpenID identities" tab on user pages.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

This one is a little risky for D7 because it is a user-facing string, but it's a pretty technical screen for them to end up at, so I think it's ok to break translations here. If David disagrees, he should feel free to revert this patch.

Committed and pushed to 7.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

Issue tags:+7.17 release notes

This is already mentioned in CHANGELOG.txt, so adding to the 7.17 release notes as well.