After upgrading a dev site to PHP 5.4, I get the following error when clearing the menu cache.

Warning: Illegal string offset '#href' in admin_menu_admin_menu_output_alter() (line 524 of admin_menu.module).

Line 524 is:
if ($link['#href'] == 'admin/tasks' || $link['#href'] == 'admin/index') {

In this case $link is not always an array. PHP 5.3 ignored this, but it is now a warning in 5.4.

CommentFileSizeAuthor
#4 admin_menu.alter-php54.4.patch595 bytessun
#3 admin-menu-illegal-offset-1472236-2.patch752 bytesdavisben
#1 admin-menu-illegal-offset-1472236-1.patch1.04 KBdavisben

Comments

davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Status: Active » Needs review
StatusFileSize
new admin-menu-illegal-offset-1472236-1.patch1.04 KB

Here's a patch to check if $link is an array.

Status: Needs review » Needs work

The last submitted patch, admin-menu-illegal-offset-1472236-1.patch, failed testing.

davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Status: Needs work » Needs review
StatusFileSize
new admin-menu-illegal-offset-1472236-2.patch752 bytes

Try again.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new admin_menu.alter-php54.4.patch595 bytes

Can you try this instead?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

davisben’s picture

davisben
Primary language English
Location NH, USA
commented

Works, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.