When creating a new node, the exclude node title checkbox is ignored. You have to edit the existing node to set it.
The reason is: the module handles this checkbox in the hook_form_submit procedure BEFORE the node is created. As a consequence, the needed node nid does not exist yet.

Please find an attached patch that moves the checkbox handling into the _nodeapi procedure which is being called after the node has been created/updated. It also removes nid from the exclude title node list when a node is being deleted.
This patch also recheck permission at submit time to avoid a forged request bypassing the authorization check.

CommentFileSizeAuthor
drupal-exclude_node_title-6.x-1.7-insert.patch4.63 KBmonnerat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gabrielu’s picture

gabrielu CreditAttribution: gabrielu commented
Status: Active » Needs review

Thanks, patch commited to DEV branch.

Let me know,
Gabriel

monnerat’s picture

monnerat CreditAttribution: monnerat commented

Thanks for having applied my patch.
But the rework you performed on the current git version fails for node deletion.
"case 'delete':" code should be reworked as you did for insert/update.
I've also noted you ported this patch to the 7.x version: 'delete' case is also left out there.

gabrielu’s picture

gabrielu CreditAttribution: gabrielu commented

Correct, thanks for noticing.
Updates commited now.

Gabriel

monnerat’s picture

monnerat CreditAttribution: monnerat commented

Mmm, I would'nt check flag presence and permission on 7.x deletion: the node disappears so its nid should be removed from our list in all cases...

gabrielu’s picture

gabrielu CreditAttribution: gabrielu commented

I couldn't agree more with you :)

Update pushed to DEV

Gabriel

gabrielu’s picture

gabrielu CreditAttribution: gabrielu commented
Status: Needs review » Closed (fixed)

Fixed

  • Commit 0b15b4c on 7.x-1.x, 8.x-1.x by gabrielu: 
    Added searchbox dependent on module + fixed node/add issue (see #1469458...