Follow up of #1448764: Ticketlist doesn't show edit link for Views.

We need to add the node ids, so we can check the right access for operations (edit/delete).

CommentFileSizeAuthor
#3 storm_views_nid-1463288-3.patch39.56 KBkfritsche
#1 storm_views_nid-1463288-1.patch7.94 KBkfritsche
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
CreditAttribution: kfritsche commented
Status: Active » Needs work
FileSize
storm_views_nid-1463288-1.patch7.94 KB

Here a patch for tickets.

If this works, then i will do this for the other content types.
For me it does, but didn't test it very well yet.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
CreditAttribution: kfritsche commented
Status: Needs work » Needs review
kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
CreditAttribution: kfritsche commented
FileSize
storm_views_nid-1463288-3.patch39.56 KB

Here now the patch for the other content types.

juliangb’s picture

juliangb CreditAttribution: juliangb commented

#3: storm_views_nid-1463288-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, storm_views_nid-1463288-3.patch, failed testing.

juliangb’s picture

juliangb CreditAttribution: juliangb commented

I don't think this is required.

@kfritsche, would you be able to elaborate on why this is needed?

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs work » Postponed (maintainer needs more info)
kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
CreditAttribution: kfritsche commented
Status: Postponed (maintainer needs more info) » Needs work

This was needed so we can have the edit links at the end of the tables in views.

Somehow it seems there are two changes here.
1. Add 'additional_fields_for_access' so fields which are needed to check for correct access are added in the views handler.
2. Make nid accessible without using node relation.

Not sure if it works correctlt, when only using the first one.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Project: Storm » Drupal PM (Project Management)
Version: 6.x-2.x-dev » 7.x-1.x-dev
Component: Storm.module » Code

Thanks for the explanation. I had thought that Views did the access checks automatically, but this isn't an area that I know much about.

I'm moving this issue into the D7 version, where Views are being used by default, and this will be easier to check.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs work » Closed (won't fix)

We're moving to using node grants, which means the views obey access controls by default.