I installed Webform 3.16 today on a minimal Drupal install (actually it was a NodeStream install, but it uses a minimal Drupal install).
When I tried to add a file field, I got a fatal error. The File module was not enabled. Shouldn't Webform depend on that?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | add_dependency_to_file-1460564-3.patch | 1.49 KB | bitkid |
| #1 | add_dependency_to_file-1460564-1.patch | 281 bytes | bitkid |
Comments
Comment #1
bitkid commentedIn case you agree to that, here is a patch that adds that dependency.
Comment #2
quicksketchAh, yes a good point!
Though I'd probably prefer to make File module optional and just make the file component depend on it. Something like
if (module_exists('file')) {in webform_component_info(). At one point File module had actually become a required module for Drupal core, but fortunately that was rolled back.Comment #3
bitkid commentedI agree that that is a better way of doing it. Require a little rewrite of the function though. Not a biggie.
Here is the patch for that.
Comment #4
quicksketchThanks, committed to the D7 branch!