I installed Webform 3.16 today on a minimal Drupal install (actually it was a NodeStream install, but it uses a minimal Drupal install).

When I tried to add a file field, I got a fatal error. The File module was not enabled. Shouldn't Webform depend on that?

CommentFileSizeAuthor
#3 add_dependency_to_file-1460564-3.patch1.49 KBbitkid
#1 add_dependency_to_file-1460564-1.patch281 bytesbitkid

Comments

bitkid’s picture

bitkid commented
StatusFileSize
new add_dependency_to_file-1460564-1.patch281 bytes

In case you agree to that, here is a patch that adds that dependency.

quicksketch’s picture

quicksketch
he/him
commented

Ah, yes a good point!

Though I'd probably prefer to make File module optional and just make the file component depend on it. Something like if (module_exists('file')) { in webform_component_info(). At one point File module had actually become a required module for Drupal core, but fortunately that was rolled back.

bitkid’s picture

bitkid commented
StatusFileSize
new add_dependency_to_file-1460564-3.patch1.49 KB

I agree that that is a better way of doing it. Require a little rewrite of the function though. Not a biggie.

Here is the patch for that.

quicksketch’s picture

quicksketch
he/him
commented
Category: feature » bug
Status: Needs review » Fixed

Thanks, committed to the D7 branch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.