Closed (won't fix)
Project:
Services
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Feb 2012 at 22:23 UTC
Updated:
1 Mar 2012 at 18:38 UTC
Patch to check if phpass module_exists, if so run the auth through its own _authenticate function rather than cores. Known 'bug' with the way phpass works. There's a core patch waiting to check for phpass, but let's be realistic - it won't get into core for 6.x
Patch probably not relevant to 7.x branch of Services, phpass method is native to D7
| Comment | File | Size | Author |
|---|---|---|---|
| services-userauth-phpass.patch | 684 bytes | Taz |
Comments
Comment #1
kylebrowning commentedComment #2
marcingy commentedWhy not alter the resource and create your own callback - I am against this patch going in and it is most certainly not a bug. And it is only used by < 800 sites. Moving back to needs review for further discussion
Comment #3
Taz commentedIf that's the case, then an altered resource hook should probably get written for the phpass module. More code for that, the entire path of that resource would have to be cloned and kept up to date with the Services one, no?
It's such a small snippet/patch, what's the big deal of it not going in the services module for D6? Remembering that D6 is not the focus anymore.
Choice: Small solution already given, or larger coding solution that has not been given.
Someone needs to put their hand up and take responsibility for modules playing nicely together #justsaying
Either way, there's the patch for those who stumble upon this problem and need a solution.
Comment #4
marcingy commentedOr putting in code to support a module when services seeks to have a policy of only supporting core, which this goes against.
Maybe you should get a phpass login service in place that gets committed to the phpass project.
Comment #5
kylebrowning commentedpeople can do this by overriding methods, or creating their own, this won't be going into core as Marcingy has said.