[D7] ExtraWatch

Need a link to your project page, at least.

Please add the sandbox link to the issue summary. Don't forget to set the status to "needs review" if you want to get a review.

The response time for a review is now approaching 4 weeks. Get a review bonus and we will come back to your application sooner.

Check out this link to an automated review of your module for drupal coding standards. Looks like you've got a lot of work to do to get this drupal ready :X
http://ventral.org/pareview/httpgitdrupalorgsandboxmatto3c1452324git

Manual Review:

I'm not positive what the rules are with drupal modules, but I'm pretty sure that modules with Free and Pro versions are not allowed. At least, I've never seen any other contributed module with that model...I've also never been asked to sign a license agreement in a contrib module. Again, I'm no expert on licensing topics, but I'm confident that's not in line with the drupal style.

Also your module seems to do most of its work by itself, ignoring Drupal's core functionality, It seems like it has some pretty great features, but it isn't really integrated with drupal, which has me questioning its possibility of being an official contrib module. As I see it, the project application process is as much about proving that you're a capable, knowledgable, security-conscious drupal developer.

As a side note, your module seems to register admin/overlay as a menu item, which I think could be pretty confusing as there is already an overlay module in drupal core. I'd consider changing that name around.

I'm leaving this as 'needs review' until someone more experienced can come in and comment. That said, I do feel as though you're going to have a hard time getting this module through the review process without a very serious overhaul. I understand that the module is a port of a plugin for Joomla and Wordpress, and it seems like it has great functionality...but the review process here is pretty stringent.

Of course you can absolutely market and and distribute your module however and wherever you'd like, but to have it entered as an official contrib module here on drupal.org, I'm fairly sure you'll need to get it through the stringent rules of the review process.

http://drupal.org/node/539608 explains the detail of what to expect form the application here. Maybe that will help clear up what's you have to do to get the module in.

I'm very sorry for the delay but there are currently about 160 other applications in the queue and only a hand full of reviewers (and also they got a job to do)

I can really understand your desperation with the process, I also got through it and it took months - that was the reason I took the initiative and helped out my self.

Please consider helping out in the queue your self, get a review bonus and we will come back to your application sooner.

@Matto3c, I run your git repo on http://ventral.org/pareview/httpgitdrupalorgsandboxmatto3c1452324git again and there is a lot todo. I fully understand your feelings about the review process. When I first wanted to contribute a module years ago I was also frustrated. But - we not only have to accept this stringent process, we should actually love it. Just because it makes Drupal better, more stable and secure.

So - you may either start to rewrite the module or you ask for a co-maintainer. Btw. you could also use Coder http://drupal.org/project/coder which makes drupalify code much easier.

I'm sorry but just have a look into the queue, there are about a hundred applications waiting for more then 15 weeks.
As said, we do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

Hello,

I get

Warning: Cannot modify header information - headers already sent in drupal_goto() (line 685 of C:\xampp\htdocs\drupalclean\includes\common.inc).

After enabling the module

Clicking on extrawatch on the menu gives me

Strict warning: Only variables should be assigned by reference in ExtraWatch->ExtraWatch() (line 38 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).
Strict warning: Only variables should be assigned by reference in ExtraWatch->ExtraWatch() (line 38 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).
Strict warning: Only variables should be assigned by reference in ExtraWatch->ExtraWatch() (line 38 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).

The page after agreeing to the conditions says "A real-time AJAX joomla monitor" which might confuse people

Visiting some content to test the viewer gives me

Strict warning: Only variables should be assigned by reference in ExtraWatch->ExtraWatch() (line 38 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).
Strict warning: Only variables should be assigned by reference in ExtraWatch->ExtraWatch() (line 38 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).
Strict warning: Only variables should be assigned by reference in ExtraWatch->ExtraWatch() (line 38 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).
Strict warning: Only variables should be assigned by reference in ExtraWatchVisit->ExtraWatchVisit() (line 36 of C:\xampp\htdocs\drupalclean\sites\all\modules\extrawatch\components\com_extrawatch\class.extrawatch.visit.php).

Sorry this doesn't help much.

I'd consider hook_permissions and hook_help to make sure the module is easy to use and also that only certain people can access the view.

Matt,

Although it may seem stringent, I think it will really help your review process if you read and follow some of the basic application guidelines such as;

http://drupal.org/node/1011698
Fill out the issue form:

• A link to your project page.
• A direct link to your git repository (git clone ...).
• Please specify if it's for Drupal 6 and/or 7.
• A list of links to reviews of other project applications that you did.

Tips for ensuring a smooth review - http://drupal.org/node/1187664

Also, still throwing errors - http://ventral.org/pareview/httpgitdrupalorgsandboxmatto3c1452324git

Please see on Best Practices and Working with the Drupal API.

This code does not even resemble a Drupal module. It's ~20 MB uncompressed, while most modules are 8-80KB compressed.

I apologize for using the harshest status change, but in its current form, this is unable to be reviewed. Good luck continuing to learn Drupal. I recommend you check out the resources in http://skillcompass.org/topic/drupal-coding and http://skillcompass.org/topic/contrib-apis to get a good sense of what APIs are available.

> this is a shame
In part, yes. But think of the larger context. Maybe try learning a few new things while you're at it.

> the 20 MB are because most of it are the geolocation data.
Makes sense... but still screams 3rd party liability. Please look at How to review Full Project applications to get a sense of how I'm looking at this.

> I wonder why wordpress and joomla have no problems with this extension.
To be honest, it makes no difference.

> You want people to contribute, but after contributing the free version, you create obstacles.
I want to help people contribute, yes. But talking about free versus non-free versions doesn't jive with the philosophy behind Drupal. So, I'd be happy to help you get more involved, but it wouldn't lead toward me recommending non-free code to the community. That's just simply out of the question.

> The code is written the way that it uses minimum of drupal API, that's true. But it's because of being able to work with no CMS at all.
Hmm. I don't really know what to say about this. This is the first time anyone has presented me with that logic. So, I'd recommend further analysis on your part. I'll probably update the docs with a statement about this if someone else submits similar code, but, it's a lot more common for people to seek to extend Drupal.

> Did you even try to install it to see what it does?
I'm sorry, but my code smell-o-meter says bad things. As you can see, I value Drupal's core and contributed APIs very much. I'm not trying to stop you from working with people on drupal.org, but I don't see a point to reviewing this code and would recommend others prioritize more relevant code for the community.

Last minute edit: So the answer is yes, I /very/ briefly looked at it earlier to make the call I made above, and I haven't changed my mind about... but it does appear you have /some/ knowledge of Drupal practices and php coding experience. So I am more interested to read code you may contribute later, but until then, I can only offer words of encouragement along the path.

> http://www.codegravity.com/demo/joomlawatch/1.2.17/
This demo is for joomla and contains errors which don't even appear to be Drupal related:

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /data/c/o/codegravity.com/web/demo/joomlawatch/1.2.17/index.php:128) in /data/c/o/codegravity.com/web/libraries/joomla/session/session.php on line 423

Warning: Cannot modify header information - headers already sent by (output started at /data/c/o/codegravity.com/web/demo/joomlawatch/1.2.17/index.php:128) in /data/c/o/codegravity.com/web/libraries/joomla/session/session.php on line 426

Please understand, I'm not interested in reviewing this linked site any further.

>I respect your decision
I appreciate that.

> I still can't understand your opposition against these new modules on platform which is a growing platform and needs interesting modules to attract new users to get better market share.
I think my responses above should make a response to this point unnecessary.

Do you have any more questions regarding this application and the application review policies? If not, you can change this issue back to the old status to help me out a bit.

Hi Mattoc3,

I don't mean to discourage you but I'm just going to list code changes / recommendations as I see them.

1. hook_menu comment doc does not sit above your hook_menu function in extrawatch.module.
2. You still have constants such as JPATH_BASE which is obviously from Joomla. You should take advantage of the Drupal API with methods such as drupal_get_path().
3. Don't use require_once() instead use module_load_include()
4. Consider following the Drupal Coding Standards. For example bring your first bracket onto the same line as your function declaration, add doc block comments to all functions, don't excessively go over the 80 character line limit, etc.
5. Use hook_schema() to create your database tables when the module is installed.
6. Use drupal_set_message() to give feedback to the user rather than simply echoing the content to the page.
7. Use drupal_access_denied() when denying access to specific files / pages. You should setup a new role and permissions to be used with your menu callbacks. @see user_access()

I know it seems like a lot but it will be worth it in the end.

Good luck :)

Sorry to hear your frustration. Feel free to reopen this application or create a new one for another project whenever you get back to Drupal.