Hi,

Installing the module has allowed me to see the new settings in Views configuration, but the Carousel was not working at all.
You'll find attached the modification I've done to the module to have it kinda working. I'm still encountering issues regarding the jcarousel skin, otherwise, module is working perfectly with the patch.

Does anybody have the same issues?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

2pha’s picture

I can't even seem to find the options in the view settings.
I would expect it to be in the format settings...maybe a jcarousel option in the 'slideshow type' combobox?

2pha’s picture

Sorry, just found the settings under 'pager type'

Simon Georges’s picture

Status: Active » Needs review

Changing status, as there is a patch.

martinedstrom’s picture

I get the carousel to display thumbnails with the patch installed - but it does not function properly.

The carousel thumbnails are displayed on row upon row instead of in a single line, and there are no arrows to control the carousel. I can see the skins 'ie7' and 'tango' in the Views Slideshow settings, but changing this option does not make anything happen.

It seems the skins are not implemented properly with this patch, and because of that it does not provide such basic functionality as the jcarousel arrow controls?

Help would be much appreciated.

Simon Georges’s picture

Indeed, there still are issues with the jcarousel theme, but I'm not good enough at js to debug them... I was happy enough when I add the pager appear. Let's just hope someone else will step up and finish the work ;)

aDarkling’s picture

Thanks, Simon - the patch works!

It desperately needs to be committed. Between the module being DOA & the utter lack of documentation, I lost a whole day on this thing!

martinedstrom, your problem stems from the css not working. The default files in /sites/all/libraries/jcarousel/skins expect an additional skin-specific wrapper like "jcarousel-skin-tango" which isn't generated by drupal. You can either add this class to the views settings, or copy the css to your theme and either take out or substitute the non-existent class.

Simon Georges’s picture

Status: Needs review » Reviewed & tested by the community

Well, let's start by changing the status, maybe that will motivate the maintainers ;-)
Thanks for your feedback, anyway!

jwilson3’s picture

Category: support » bug

+1, bump.

The patch in OP is good and RTBC. Marking this as a bug, because thats really what it is.

jwilson3’s picture

Title: Should the module work directly after installation? » carousel initialization bug
Priority: Normal » Critical

Updated the title and priority to something more relevant. Without this patch, the module is completely broken.

jwilson3’s picture

Title: carousel initialization bug » jcarousel is never initialized properly
eloivaque’s picture

In the theme bartik the module works, but in theme omega don't work. If apply this patch, work.

jwilson3’s picture

@eloiv: good to know! can you tell us: after you apply the patch, does the jcarousel *still* work in bartik?

Hopefully this is an improvement and does not create a regression.

zeropx’s picture

I am working on a site using Omega Theme and upon installation of the module. Did not work as anticipated. This patch does in fact fix it to work with the OMEGA THEME.

Simon Georges’s picture

Title: jcarousel is never initialized properly » jCarousel is never initialized properly with Omega theme
knalstaaf’s picture

Status: Reviewed & tested by the community » Needs review

Working with the latest Omega theme (7.x-3.1) and the module is working in Views itself, but when I have a look at the page where the carousel is in, it doesn't work indeed.

Applied the patch, but it isn't working at all anymore, in Views itself nor on the page. The thumbs are now arranged next to each other on the page itself, but as bullets in Views itself, both are displayed without a skin now. Tried #6 to no avail.

It even broke the whole pager-functionality when viewed in Views (main slide doesn't change anymore when thumbs are being clicked). It's like the link with the skin is totally broken on the page (even skin-related CSS classes are gone, like "tango").

That doesn't feel ok.

knalstaaf’s picture

This is the View in case it may provide useful information (it's pretty basic):

$view = new view;
$view->name = 'slideshow';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'node';
$view->human_name = 'Slideshow';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['query']['options']['query_comment'] = FALSE;
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['exposed_form']['options']['reset_button_label'] = 'Opnieuw instellen';
$handler->display->display_options['pager']['type'] = 'none';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['style_plugin'] = 'slideshow';
$handler->display->display_options['style_options']['slideshow_type'] = 'views_slideshow_cycle';
$handler->display->display_options['style_options']['slideshow_skin'] = 'default';
$handler->display->display_options['style_options']['skin_info'] = array(
  'class' => 'default',
  'name' => 'Standaard',
  'module' => 'views_slideshow',
  'path' => '',
  'stylesheets' => array(),
);
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['weight'] = '1';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['type'] = 'views_slideshow_pager_fields';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['views_slideshow_pager_fields_fields'] = array(
  'field_foto_s' => 0,
  'field_foto_s_1' => 0,
);
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['views_slideshow_jcarousel_pager_orientation'] = '0';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['views_slideshow_jcarousel_pager_scroll'] = '3';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['views_slideshow_jcarousel_pager_visible'] = '3';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_pager']['views_slideshow_jcarousel_pager_wrap'] = '';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_controls']['weight'] = '1';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_controls']['type'] = 'views_slideshow_controls_text';
$handler->display->display_options['style_options']['widgets']['top']['views_slideshow_slide_counter']['weight'] = '1';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['enable'] = 1;
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['weight'] = '1';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['type'] = 'views_slideshow_jcarousel_pager';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['views_slideshow_pager_fields_fields'] = array(
  'field_foto_s_1' => 'field_foto_s_1',
  'field_foto_s' => 0,
);
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['views_slideshow_jcarousel_pager_orientation'] = '0';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['views_slideshow_jcarousel_pager_scroll'] = '3';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['views_slideshow_jcarousel_pager_visible'] = '6';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_pager']['views_slideshow_jcarousel_pager_wrap'] = 'both';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_controls']['weight'] = '1';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_controls']['type'] = 'views_slideshow_controls_text';
$handler->display->display_options['style_options']['widgets']['bottom']['views_slideshow_slide_counter']['weight'] = '1';
$handler->display->display_options['style_options']['views_slideshow_cycle']['timeout'] = '5000';
$handler->display->display_options['style_options']['views_slideshow_cycle']['speed'] = '700';
$handler->display->display_options['style_options']['views_slideshow_cycle']['delay'] = '0';
$handler->display->display_options['style_options']['views_slideshow_cycle']['start_paused'] = 0;
$handler->display->display_options['style_options']['views_slideshow_cycle']['remember_slide_days'] = '1';
$handler->display->display_options['style_options']['views_slideshow_cycle']['items_per_slide'] = '1';
$handler->display->display_options['style_options']['views_slideshow_cycle']['wait_for_image_load_timeout'] = '3000';
$handler->display->display_options['style_options']['views_slideshow_cycle']['cleartype'] = 0;
$handler->display->display_options['style_options']['views_slideshow_cycle']['cleartypenobg'] = 0;
$handler->display->display_options['row_plugin'] = 'fields';
$handler->display->display_options['row_options']['hide_empty'] = 0;
$handler->display->display_options['row_options']['default_field_elements'] = 1;
/* Veld: Inhoud: Foto's */
$handler->display->display_options['fields']['field_foto_s']['id'] = 'field_foto_s';
$handler->display->display_options['fields']['field_foto_s']['table'] = 'field_data_field_foto_s';
$handler->display->display_options['fields']['field_foto_s']['field'] = 'field_foto_s';
$handler->display->display_options['fields']['field_foto_s']['label'] = '';
$handler->display->display_options['fields']['field_foto_s']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['external'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['field_foto_s']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['field_foto_s']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['trim'] = 0;
$handler->display->display_options['fields']['field_foto_s']['alter']['html'] = 0;
$handler->display->display_options['fields']['field_foto_s']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['field_foto_s']['element_default_classes'] = 1;
$handler->display->display_options['fields']['field_foto_s']['hide_empty'] = 0;
$handler->display->display_options['fields']['field_foto_s']['empty_zero'] = 0;
$handler->display->display_options['fields']['field_foto_s']['hide_alter_empty'] = 1;
$handler->display->display_options['fields']['field_foto_s']['click_sort_column'] = 'fid';
$handler->display->display_options['fields']['field_foto_s']['settings'] = array(
  'image_style' => 'slide',
  'image_link' => '',
);
$handler->display->display_options['fields']['field_foto_s']['group_rows'] = 0;
$handler->display->display_options['fields']['field_foto_s']['delta_offset'] = '0';
$handler->display->display_options['fields']['field_foto_s']['delta_reversed'] = 0;
$handler->display->display_options['fields']['field_foto_s']['delta_first_last'] = 0;
$handler->display->display_options['fields']['field_foto_s']['field_api_classes'] = 0;
/* Veld: Inhoud: Foto's */
$handler->display->display_options['fields']['field_foto_s_1']['id'] = 'field_foto_s_1';
$handler->display->display_options['fields']['field_foto_s_1']['table'] = 'field_data_field_foto_s';
$handler->display->display_options['fields']['field_foto_s_1']['field'] = 'field_foto_s';
$handler->display->display_options['fields']['field_foto_s_1']['label'] = '';
$handler->display->display_options['fields']['field_foto_s_1']['exclude'] = TRUE;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['external'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['more_link'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['trim'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['alter']['html'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['field_foto_s_1']['element_default_classes'] = 1;
$handler->display->display_options['fields']['field_foto_s_1']['hide_empty'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['empty_zero'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['hide_alter_empty'] = 1;
$handler->display->display_options['fields']['field_foto_s_1']['click_sort_column'] = 'fid';
$handler->display->display_options['fields']['field_foto_s_1']['settings'] = array(
  'image_style' => 'slide_thumb',
  'image_link' => '',
);
$handler->display->display_options['fields']['field_foto_s_1']['group_rows'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['delta_offset'] = '0';
$handler->display->display_options['fields']['field_foto_s_1']['delta_reversed'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['delta_first_last'] = 0;
$handler->display->display_options['fields']['field_foto_s_1']['field_api_classes'] = 0;
/* Sort criterion: Inhoud: Post date */
$handler->display->display_options['sorts']['created']['id'] = 'created';
$handler->display->display_options['sorts']['created']['table'] = 'node';
$handler->display->display_options['sorts']['created']['field'] = 'created';
$handler->display->display_options['sorts']['created']['order'] = 'DESC';
/* Contextual filter: Inhoud: Nid */
$handler->display->display_options['arguments']['nid']['id'] = 'nid';
$handler->display->display_options['arguments']['nid']['table'] = 'node';
$handler->display->display_options['arguments']['nid']['field'] = 'nid';
$handler->display->display_options['arguments']['nid']['default_action'] = 'default';
$handler->display->display_options['arguments']['nid']['default_argument_type'] = 'node';
$handler->display->display_options['arguments']['nid']['default_argument_skip_url'] = 0;
$handler->display->display_options['arguments']['nid']['summary']['number_of_records'] = '0';
$handler->display->display_options['arguments']['nid']['summary']['format'] = 'default_summary';
$handler->display->display_options['arguments']['nid']['summary_options']['items_per_page'] = '25';
$handler->display->display_options['arguments']['nid']['break_phrase'] = 0;
$handler->display->display_options['arguments']['nid']['not'] = 0;
/* Filter criterion: Inhoud: Gepubliceerd */
$handler->display->display_options['filters']['status']['id'] = 'status';
$handler->display->display_options['filters']['status']['table'] = 'node';
$handler->display->display_options['filters']['status']['field'] = 'status';
$handler->display->display_options['filters']['status']['value'] = 1;
$handler->display->display_options['filters']['status']['group'] = 1;
$handler->display->display_options['filters']['status']['expose']['operator'] = FALSE;
/* Filter criterion: Inhoud: Type */
$handler->display->display_options['filters']['type']['id'] = 'type';
$handler->display->display_options['filters']['type']['table'] = 'node';
$handler->display->display_options['filters']['type']['field'] = 'type';
$handler->display->display_options['filters']['type']['value'] = array(
  'productpagina' => 'productpagina',
);

/* Display: Slideshow producten */
$handler = $view->new_display('block', 'Slideshow producten', 'block');
$handler->display->display_options['block_description'] = 'Slideshow producten';
$translatables['slideshow'] = array(
  t('Master'),
  t('more'),
  t('Apply'),
  t('Opnieuw instellen'),
  t('Sort by'),
  t('Asc'),
  t('Desc'),
  t('Alle'),
  t('Slideshow producten'),
);
knalstaaf’s picture

Performed patch on a clean install -> same issue.

And what's more: when switching back to the Bartik theme, it seems to be broken there as well after being patched.

So I understand the maintainer of the module is rather reluctant when it comes to committing this patch.

Simon Georges’s picture

Status: Needs review » Needs work

As it's only relevant to Omega theme, I suppose the fix should indeed be something else than what I'm proposing.

aquadrop’s picture

The problem in my case is: in the "Edit view" page, the jCarousel theme is read correctly, that is, the correct class is applied to the carousel. Sthg like that:

      <div class="views-slideshow-controls-top clearfix">
      <div class=" jcarousel-skin-[skinname]"><div class="views_slideshow_jcarousel_pager views-slideshow-jcarousel-pager-processed jcarousel-container jcarousel-container-horizontal" id="..." style="position: relative; display: block; ">
  <div class="jcarousel-clip jcarousel-clip-horizontal" style="position: relative; ">
<ul class="jcarousel-list jcarousel-list-horizontal" style="overflow: hidden; position: relative; top: 0px; margin: 0px; padding: 0px; left: 0px; width: 428px; "> 
  ... 

In the frontend the correct class isn't applied, eg I get this:

<div class="views-slideshow-controls-top clearfix">
      <div class="views-slideshow-jcarousel-pager" id="...">
  <ul>
    ..
  </ul>
</div>
    </div>

Besides, the markup seems to be rather different (for instance, in the frontend I don't get the <div class="jcarousel-clip jcarousel-clip-horizontal" style="position: relative; "> ).

Hope it helps get some patch soon.

drupalerocant’s picture

Module working on Seven theme, but not in Omega. Patch makes module works on Omega, but stops working on seven.

Nick Robillard’s picture

After patching, pagers arrows still did not initialize as expected. Adding template hooks as described here #1700254: Omega and Views Slideshow JCarousel did work.

Po3t’s picture

Any progress on this? This module is pretty much useless with the Omega Theme until we can solve this problem...

Klikster’s picture

Dealing with this issue on an Omega theme I'm working on as well, does anyone know of any other modules I can create a Carousel with? I'm not entirely sure how to apply the patch.

zeropx’s picture

Klikster,

Here is a reference for you for applying patches: http://drupal.org/patch/apply

Aniruddhsinh’s picture

Status: Needs work » Fixed

Thanx a lot Simon Georges and #6.I had thought it might be creating such an issue because of some wrong configuration of view from my side but when I checked this post and tried it worked for me. I applied "jcarousel-skin-tango" class in view settings and also the patch. Finally it worked.

Simon Georges’s picture

Status: Fixed » Needs work
xamount’s picture

This patch worked for me. Wish I had found it 12 man hours ago..

zincdesign’s picture

I can't get this patch to work. The best I can get it to do is make the thumbnails go horizontal but all the thumbnails show and there are no arrows. I am really puzzled why there hasn't been a new version of this module released which works with Omega.

I've spent a whole day on this and I am at a loss :-(

netw3rker’s picture

Issue summary: View changes

I just stepped up to be a co-maintainer for views_sideshow_jcarousel and am going through all the issues here & applying what needs to be applied. This had some legs for a while and it'd be good to get it resolved. What i'd like to see is a patch that works in Bartik, Seven, and Omega before I'll accept it. To answer @zincdesign 's question in #28, we can't fix our generic display of slideshows to meet the dynamic requirements of every theme out there, so the solution to this problem has to work in all themes - thus proving that it's not fixing a problem introduced by omega.

I'll keep this on my radar though. Thanks for all (literally years of) the hard work!

netw3rker’s picture

Status: Needs work » Closed (fixed)

Update: I set up an environment with the omega theme. things loaded and ran correctly. I'm guessing that one of two things happened. Either A) the patch that properly applies classes in one of the preprocess functions fixed this problem, or B) omega actually fixed whatever was causing thing w/in their theme code. Either way, it seems as if this is working correctly now.

Please re-open this issue if you feel that this needs to be re-evaluated.
Thanks!