Add support for entity id tokens during creation

See also #1865432: Empty node title on initial creation.

Okay, try this one.

The drupal_goto() is to prevent a 404 when the URL alias changes because the title changed.

I used $node->title because there is a node_save() right after it, as in the node_operations code.

Actually, IMHO the 404 issue is caused by core. Node_save() specifically does a drupal_goto("node/$node->nid"). Somewhere in core (I think), it gets translated to 'node/alias' and this is the root of the problem.

One solution can be to use the module "Serial Field"
http://drupal.org/project/serial

Then add this patch:
http://drupal.org/node/615410#comment-5530710

Then you can even make id numbers for each content type, e.g. video 1, video 2, photo 1, video 3

@matsbla: No, that doesn't address this issue at all. As it turns out, I am using Serial in the same content type (and even in the title).

On creating new content Drupal sets a message displaying the title which still reflects the missing nid for example:

Content type title () has been created.

To rectify this add

 auto_entitylabel_set_title($node, 'node');

into the hook_node_insert(). Which sorts now adds the nid in the message like the example below:

Content type title (13) has been created.

Thanks for starting this patch off @NancyDru, here's the patch again with the suggestion from the reviews above. The biggest changes I've made is that this now supports all entities, rather than just node. I've also reintroduced the dependency on the entity module for the function entity_save().

Thanks for the review!

I discovered after posting the patch that the auto_entitylabel_is_needed check is needed. I fixed that by adding an optional "reset" argument to auto_entitylabel_is_needed(), the downside with that approach is that the title will be reset every time an auto labelled entity is inserted [edit: I was thinking update, it's only inserted once so this should be fine].

The call to auto_entitylabel_set_title() is purely so in the "[bundle] [title] has been created." message shown after saving a node shows the title.

I've just done a quick test with the title module and that seems to work just fine.

Here's an updated patch.

Tested tonight with a node that had a nid in it's title and it worked perfectly.

Looks good to me.

This works, but has one little bug.

After saving the node, the node cannot be found at first, because [node:id] is not added to the path, that opens the new created node!

Yes, I am using Path Auto!
For the title I just used: tf[node:nid]

I found another bug, when using Entity Reference Module and use the Autocomplete Field, the title is not created when saving the Node for the first time. When updating the node, the Title also get updated!

Regards,

Tobi

For the title created by Automatic Entity Label, I just used: tf[node:nid]
The Pattern for Path Auto is: media/[node:title]

And after saving the node Drupal was looking just for: media/tf
Without the NID. BUT the title is saved correctly, seems, somethings broken with the redirect?!

Regards,

Tobi

Setting back to fixed. Thanks for this commit!

I've downloaded the last patch in the thread and attempted to apply it, the patch fails. Can some one advise me if this patch is current and if not how I might modify it for the latest version?

This might be a bug report but it seems likely to be related to this issue so I will post it here first.

The patch in dev doesn't appear to work when the entity is previewed rather than saved. Instead it displays "%AutoEntityLabel%" for the title.

Steps to reproduce on clean install of Drupal 7:

1. Install and enable auto_entitylabel, entity, token
2. Create a new content type with text field "field1"
3. Set "node auto label" to "Automatically generate the label and hide the label field" and in "Pattern for the title" put: [node:field_field1]
4. Create new content of that content type and preview. See attached png.

I got the same problem of #23

But with the serial field.
The title gets saved correctly at one go, no rules.
Path auto is enabled and used following
[node:content-type:name]/[node:title]
the node title there is not yet complete, the serial field is missing, but when looking at content listing, the title is complete and the node is created ok.
When disabling path auto and node/xxx is being used, redirect is ok.
Looking all over the place for the source of this problem.

same as #23 with setup

pathauto
Default path pattern (applies to all content types with blank patterns below)
content/[node:title]

auto entity label
Automatically generate the label and hide the label field
SMS-[node:nid] [node:created:short]

When new node is saved its title is correctly set with SMS-1255 05/27/2015 - 18:31 but redirecting to 404 with path content/sms-05272015-1831 (notice nid token is not replaced in path) instead of content/sms-1255-05272015-1831 which is created and exist after node save.

I too am suffering this issue the same as #23 but I hacked an older version of the module some time ago and cant for the life of me remember where I read the post nor can I find any comments I made on it but after installing the latest version I experienced the site breaking with issue #23 but after reverting the module back to my older hacked version and all is fine. I will dig around a bit more and try to compare the 2 versions to see what I changed however the file is dated 26/09/14 so it was some time ago and I imagine there have been many more changes since then.

I have uploaded the hacked version of my module in case anyone else wants to try it or look at it.

My lesson here is to document any hacks I do in a separate text file within the module directory in the future ;-)

Hi,
on my site users are able to create and save nodes but not to publish them and [node:nid] wasn't working on node saved, it was only when node where published. The hacked version in comment #33 worked for me: now nid are included in new nodes even if they are just saved and not published.

Sorry, actually my last comment is not true, the problem is different and a bit strange. I have the option "Automatically generate the label if the label field is left empty". With the last version or last dev, if I choose just [node:nid] it works, but if I add some text before or after it it doesn't and only that text is inserted in the node title. Then, if I edit the node, empty the title field and save, then it works.

I needed this for a non-Title field, which while this module implies it does it, it doesn't. Here's my code from D5 that auto incremented a Title field (w/ nodetitles module).

  $output = "Quote XXX";
  if (arg(0) == 'node' && arg(1) == 'add'){
    $result= db_query('
    select max( s.id ) 
    from sequences as s
    where s.name = "node_nid"
    ');
    if(mysql_num_rows($result)){
      $sid = mysql_fetch_array($result,MYSQL_NUM);
      $s_id = $sid[array_rand($sid)];
    }
    $s_id =$s_id +1;
    $output = "Quote $s_id";
  } elseif (arg(0) == 'node' && is_numeric(arg(1))) {
    $nodeid = arg(1);
    $output = "Quote $nodeid";
  } else {
    # just fooked...
    $output = "Quote nnn";
  }
  print $output;

There's always a better way, but this worked, without errors, on a fairly busy site. Translate to D7 as needed.

Best

Guys. This is still not working (from the dev version). Clean install and the [node:nid] token is not being replaced when creating a new node. Am I missing something. Somehow, the if (auto_entitylabel_is_needed($entity, $type, TRUE)) statement is being evaluated as false when creating a new node.