Product pickup address should not require first/last name

Here's the error:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'first_name' cannot be null: INSERT INTO {uc_quote_product_locations} (nid, first_name, last_name, company, street1, street2, city, zone, postal_code, country, phone) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10); Array ( [:db_insert_placeholder_0] => 1973 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => [:db_insert_placeholder_3] => [:db_insert_placeholder_4] => [:db_insert_placeholder_5] => [:db_insert_placeholder_6] => [:db_insert_placeholder_7] => [:db_insert_placeholder_8] => [:db_insert_placeholder_9] => [:db_insert_placeholder_10] => ) in uc_quote_node_update() (line 121 of /mnt/www/html/aaviddev/docroot/sites/all/modules/ubercart/shipping/uc_quote/uc_quote.module)

This is still very much an issue and it's breaking my site. I'm looking at your dev code and it's still doing exactly what's causing this. I have no idea how you're unable to reproduce it because the code does do it. ;-)

uc_quote_form_alter:

 196     // Use the store default if the product does not have an address set.
 197     if (empty($address)) {
 198       $address = variable_get('uc_quote_store_default_address', new UcAddress());
 199     }

uc_quote_node_update:

 106     if (!empty($node->shipping_address['street1'])) {
 107       db_merge('uc_quote_product_locations')
 108         ->key(array('nid' => $node->nid))
 109         ->fields(array(
 110           'first_name' => $node->shipping_address['first_name'],
 111           'last_name' => $node->shipping_address['last_name'],
 112           'company' => $node->shipping_address['company'],
 113           'street1' => $node->shipping_address['street1'],
 114           'street2' => $node->shipping_address['street2'],
 115           'city' => $node->shipping_address['city'],
 116           'zone' => $node->shipping_address['zone'],
 117           'postal_code' => $node->shipping_address['postal_code'],
 118           'country' => $node->shipping_address['country'],
 119           'phone' => $node->shipping_address['phone'],
 120         ))
 121         ->execute();
 122     }

uc_quote_install:

  42   $schema['uc_quote_product_locations'] = array(
  43     'description' => 'Stores default product origin addresses.',
  44     'fields' => array(
  45       'nid' => array(
  46         'description' => 'The {uc_products}.nid.',
  47         'type' => 'int',
  48         'unsigned' => TRUE,
  49         'not null' => TRUE,
  50         'default' => 0,
  51       ),
  52       'first_name' => array(
  53         'description' => 'The address first name.',
  54         'type' => 'varchar',
  55         'length' => 255,
  56         'not null' => TRUE,
  57         'default' => '',
  58       ),
  59       'last_name' => array(
  60         'description' => 'The address last name.',
  61         'type' => 'varchar',
  62         'length' => 255,
  63         'not null' => TRUE,
  64         'default' => '',
  65       ),

Those 'not null's, combine with your pre-populating the product address with the store default are causing PDO errors when the store default address doesn't have first and last name. This is critical as it is breaking the ability to update nodes on a live site (we get a fatal). At the very least, you need to allow null values for first and last name, but second, why are you pre-populating with the store default at all? That makes no sense - if the store default changes, now I've got to manually update several thousand product with the new address even though I never actually intended them to be anything other than the default? Why is uc_quote even doing that at all? It's beyond crazy to do that to me. If you've got a reason for doing that, I'd love to hear it.

Sorry for the bold, but that specific set of questions was never answered and as far as I am concerned is just as important as the fatal error due to the maintenance headaches that will cause down the road. That is completely unexpected and unwanted behavior.

Just figured out why you can't reproduce it - you've got no street address (uc_quote checks against that before the insert). Give yourself a company name and street address and watch the fatals begin. ;-)