Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Is there any interest in rewriting this module? I would like to better organize the CSS so it's easier to style active and hover states for parent and child elements. It would also be nice to separate the background and border styles from layout and position styles. Maybe someone should do research about the best techniques for CSS based dropdown menus, CSS best practices for contributed modules and generate a features list that can be prioritized. I wouldn't mind starting off a new branch.
Comments
Comment #1
vordude CreditAttribution: vordude commentedNot a bad idea.
There are a couple of older issues, that I'd like to work into a rewrite if it all possible.
That said, I don't want to throw the baby out with the bathwater so to speak.
There are some pretty nasty theme functions that I'd like to change into template files for ease of theming. Any thoughts on that?
Comment #2
squiggy CreditAttribution: squiggy commentedYes I definitely agree with not throwing everything out. I would be happy to work on any features that you recommend.
I'll proceed with reviewing everything. That should turn up more specifics areas for improvement.
Comment #3
klonos@vordude: Hey Matt, there are a couple of your commits lately that removed files from the 7.x-2.x branch. I noticed this after I saw a significant decrease in the file size of the latest 7.x-2.x-dev. Was that intentional? Did you perhaps meant to start a new 3.x branch and make these changes there instead?
Comment #4
vordude CreditAttribution: vordude commentedI did some git wrangling here, and may have messed up the dev releases.
I tried to move the 7.x 2.x branch off of the git master branch and to a 7.x 2.x git branch.
I don't think this affected the "real releases" but the dev releases may be pointing to the wrong place. At this point, dev should not be ahead of the 7.x-2.1 release.
Comment #5
klonos...yeah, I noticed that the stable releases weren't effected. Just meant to give people a heads up if they're using devs.
Comment #6
DuaelFrI have just a little suggestion for an hypothetical 3.x version.
You should drop the configuration field allowing to choose the number of nice menus.
Instead you could add the ability to create a new nice menu block by defining at least an unique machine name.
Two objectives :
- create a better export/import interface to plug in Features/Deploy/whatever
- easier and cleaner access to customization using hooks
Pushing a bit further, all the configuration options deported into blocks interface could be fetched into the module configuration. In my opinion, this is where people attend to find them.
My 2 cents ;)
Comment #7
xiukun.zhou CreditAttribution: xiukun.zhou commented#2036601: Create a 7.x-3.x branch to support the latest versions of required js libraries - Keep 7.x-2.x compatible with default Drupal.
commit: 0f936b0
Comment #8
apaderno