Closed (fixed)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
14 Feb 2012 at 10:44 UTC
Updated:
7 Mar 2012 at 16:20 UTC
Jump to comment: Most recent file
A views handler to display a 'Send newsletter' link if the newsletter has not been sent yet. The link should go to the send newsletter page.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | simplenews-send_views_handler-1439688-6.patch | 2.54 KB | czigor |
| #3 | simplenews-send_views_handler-1439688-3.patch | 2.54 KB | czigor |
| #1 | simplenews-send_views_handler-1439688-1.patch | 2.82 KB | czigor |
Comments
Comment #1
czigor commentedHere comes the patch.
Comment #2
berdirYou should use the Constant here instead of == '0'. The constant is called SIMPLENEWS_STATUS_SEND_NOT.
You should add an empty line at the end of the file, diff are very unhappy if these are missing.
Comment #3
czigor commentedThanks for the review! Here comes the corrected patch.
Comment #4
czigor commentednedds review
Comment #6
czigor commentedAgain.
Comment #7
czigor commentedtag
Comment #8
berdirThanks, commited.