Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Plenty of Redis servers now use authentication. Here's a patch to add support to both drivers.
Marking this "major" because this client doesn't support a substantial set of Redis servers right now.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | redis-password-not-pass.patch | 1.19 KB | populist |
| #1 | password_support.diff | 3.33 KB | David Strauss |
| password_support.diff | 2.58 KB | David Strauss |
Comments
Comment #1
David StraussHere's an updated patch that also adds the password to the admin screen.
Comment #2
joshk CreditAttribution: joshk commented+1 for this! ;)
Comment #3
pounardYes indeed, nice feature, I will review it and probably commit it as soon as I have some spare time (I will try within the week). Thanks.
Comment #4
David StraussIf you're looking for a place to focus testing, I would try the Predis back-end with passwords. I've only really tested the native PhpRedis changes.
Comment #5
pounardReviewed your patch, just changed "PASSWORD" occurences to "PASS" only (I now am regretting this I should have named it AUTH).
Pushed and a new 7.x-2.0-alpha5 is en route and will arrive in a few minutes.
Thanks!
Comment #6
David StraussNo, it shouldn't be called "auth." The command is "AUTH," but the argument is named "password." The value is being passed in as the password argument, so the variable should be called "password." Additionally, variables ought to be nouns (like "password"), not verbs (like "auth").
Here are the docs on the command:
http://redis.io/commands/auth
Comment #7
pounardYup, I did read this page, guess you are right. Still, this is "pass" now, and if you feel it wrong, I'd be happy to revert it, but right now I'm too lazy to do it.
Comment #8
David StraussSorry to be difficult, but I would prefer "password." Normally, I wouldn't care between "pass" and "password," but we'll need to make a configuration change if the variable is "pass." Thanks.
Comment #9
pounardOkay, I will change it back, just not right now it's sunday and I need some rest, but maybe in the week.
Comment #10
populist CreditAttribution: populist commentedHere is a patch to make the change in question.
Comment #11
pounardCommited. A new release will come up in the day, thanks to both of you!
Comment #12
pounardComment #15
Marko B CreditAttribution: Marko B commentedWhy is this not in version 7.3?
Comment #16
Marko B CreditAttribution: Marko B commentedComment #17
Marko B CreditAttribution: Marko B commentedComment #19
tunicIt seems code to support password is already in module source code (both 7.x and 8.x).
Comment #20
C-Logemann@tunic Yes, I can confirm this for D9. So I was wondering about this issue update in my mail inbox.