This patch removes the core bug workaround that is now fixed, and adds a dependency on system module >= 7.12 (a better way to check for Drupal core version) in the .info file.

It also cleans up code according to Drupal coding standards (using && and || instead of AND and OR for example).

CommentFileSizeAuthor
#2 eof_newline_character.png8.95 KBSeriousMatters
#1 1439234-remove_workaround-1.patch6.16 KBMark Theunissen

Comments

Mark Theunissen’s picture

Mark Theunissen commented
StatusFileSize
new 1439234-remove_workaround-1.patch6.16 KB
SeriousMatters’s picture

SeriousMatters commented
StatusFileSize
new eof_newline_character.png8.95 KB

Thanks Mark,

I have to do some tests, especially menu_block compatibility, before committing. I'm busy lately but I promise I will come back to this when I get the chance to.

SeriousMatters’s picture

SeriousMatters commented
Status: Needs review » Fixed

committed and push.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.