Forgive me if I've missed something obvious, but it appears that with the new Date Repeat form in D7 one can select only a single byday/bymonth/etc. ordinal because of the single-valued selection list. Thus, I cannot create a date that repeats, for example, on the 1st and 3rd Fridays of every month; I can only select the 1st Friday or 3rd Friday. I could do this with the old Date Repeat form because it had a multivalued selection list. It does not appear that there is anything in the date processing that would preclude an rrule with multiple byday values, but I cannot find any way to create such an rrule through the UI.

Still, thanks for the great work on such an essential and outstanding module!

Files: 
CommentFileSizeAuthor
#29 date_repeat-multiple_day_of_week_rrule_values-1437220-29.patch5.26 KBsuhel.rangnekar
FAILED: [[SimpleTest]]: [MySQL] 4,617 pass(es), 756 fail(s), and 108 exception(s). View
#25 date_repeat-multiple_day_of_week_rrule_values-1437220-25.patch4.76 KBbgilhome
FAILED: [[SimpleTest]]: [MySQL] 4,617 pass(es), 756 fail(s), and 108 exception(s). View
#7 date_repeat-multiple_day_of_week_rrule_values-1437220-7.patch5.03 KBMatthew Davidson
FAILED: [[SimpleTest]]: [MySQL] 4,518 pass(es), 756 fail(s), and 108 exception(s). View
#4 date_repeat-multiple_day_of_week_rrule_values-1437220-4.patch3.54 KBMatthew Davidson
FAILED: [[SimpleTest]]: [MySQL] 4,518 pass(es), 756 fail(s), and 108 exception(s). View

Comments

KarenS’s picture

That would mean reworking the UI again, and that's a bear. If it's important to you you can try to figure out a patch to make it so.

Abenezer’s picture

Has anybody figured out an elegant solution to this issue? I would think that it is a very common occurrence when building websites for schools or other institutions that offer periodic event schedules. Right now I have two different clients that would like this feature on their websites — one is an architectural firm and one is a dance studio, but both need the same feature, so it has to be pretty common to run into this.

Any thoughts, or has anyone created a patch for this, or perhaps there are other modules that can mimic this functionality when used in tandem with date? If I were more of a programmer, I'd be happy to create a patch, but unfortunately the issue is way loftier than my skill levels : ) I really need to find more time to take some php courses!

Also, KarenS; Thanks so much for all of your time with this really, really robust module!

saweyer’s picture

I too was puzzled when the Advanced tab for Repeating went away in 7.x (and kept searching around for configuration settings).

Interestingly when I migrated my site from 6.26, I had 2 several events like this: e.g., with !st & 3rd Monday; -- and those values were preserved until I edited the events, and then they changed to just one of the days per month. So, I guess it is just a u.i. issue -- and not an underlying problem w/ storing the rule or multiple dates?

As an alternative to re-including the previous interface, might it be possible to just have the popup allow multiple selections, i.e., adding MULTIPLE attribute to the SELECT, which would use ctrl-click (or cmd-click on Mac) to add/subtract values?

thanks
Steve

Matthew Davidson’s picture

FileSize
3.54 KB
FAILED: [[SimpleTest]]: [MySQL] 4,518 pass(es), 756 fail(s), and 108 exception(s). View

Here's my first attempt at wrestling this particular bear. I initially intended to make more elements multiple select, but when I thought about it, I couldn't see any real-world benefit in doing so to anything but days of the week, and the form's complicated enough already.

Can't see any unintended side-effects so far.

Matthew Davidson’s picture

Status: Active » Needs review

Oops. Change status.

nairb’s picture

One thing I noticed- when you return to the edit screen only the first select item is highlighted.

Matthew Davidson’s picture

FileSize
5.03 KB
FAILED: [[SimpleTest]]: [MySQL] 4,518 pass(es), 756 fail(s), and 108 exception(s). View

Ah, yes. You're quite right. Try this.

nairb’s picture

Looks good to me. I have played with it a bit this morning and haven't noticed any issues.

Adrianm6254’s picture

I have also applied the patch and it is working great for me.

areikiera’s picture

Works great for me too!

In my case, I have events occurring on the first and third weekends. The patch allows you to select multiple values like 'First' and 'Third', but does not allow you to select both 'Saturday' and 'Sunday'. I imagine there is more complicated code needed for something like this. Someone may have an event occuring for the first and third Fridays, and the second and forth Saturdays.... so for a situation like that, it seems like having the ability to 'Add addition' (like we're able to do on 'include dates'), except for the entire fieldset of "On the _____ day of x, x, x...".

Is that possible? Is there a better approach?

Also, variable times on repeating dates would be amazing. If i have a weekend event, with times on Friday from 5pm-10pm, Saturday Noon-Midnight, and Sunday Noon-6pm, it would be great to specify those times on the repeating values. Is that separate issue worthy?

areikiera’s picture

Closed http://drupal.org/node/613614 as duplicate. The comment on http://drupal.org/node/613614#comment-4204464, is requesting the same kind of functionality as I'm requesting in my previous comment here #10.

nairb’s picture

If you set the event to start on Saturday and end on Sunday, you can set it to repeat on the 1st and 3rd Saturdays and it will cover each weekend.

areikiera’s picture

@nairb: Thanks! That's a good idea, but in my case I'm grouping by day, and events that span multiple days (instead of repeating each day) only show up on the first day, and I need it to show up on each day it spans (as noted in this issue: http://drupal.org/node/1960240). Is there a way to configure the view so spanning events show up on each day that I'm not aware of?

There is also the case that an event may have different hours on Saturday than on Sunday, but that's more related to the variable hours option.

Thanks!

awt’s picture

I've applied the patch and it works !
Thanks :)

For those who don't know how to patch : http://drupal.org/patch/apply
(I had to look for myself first, so maybe there are others like me)

Status: Needs review » Needs work

The last submitted patch, date_repeat-multiple_day_of_week_rrule_values-1437220-7.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, date_repeat-multiple_day_of_week_rrule_values-1437220-7.patch, failed testing.

Renee S’s picture

This patch worked great for me.

Renee S’s picture

Status: Needs work » Reviewed & tested by the community
vijaycs85’s picture

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: date_repeat-multiple_day_of_week_rrule_values-1437220-7.patch, failed testing.

heddn’s picture

#2127497: Spam Report opened.

I think the reason #7 doesn't pass tests is because of brittle tests. The actual patch seems to operate correctly.

vijaycs85’s picture

Issue summary: View changes
Issue tags: +Needs tests

we may need to fix the test cases...

bgilhome’s picture

FileSize
4.76 KB
FAILED: [[SimpleTest]]: [MySQL] 4,617 pass(es), 756 fail(s), and 108 exception(s). View

Here's an updated patch against the latest 2.x HEAD. Some variables names had changed (lowercase).

bgilhome’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
echoz’s picture

Issue tags: +Needs reroll

Since the latest patch in #25 (Sep 3), there's a newer dev (Oct 2) besides a newer release version (Sep 8). Anyone for a reroll, or is this patch still working in 7.x-2.9 except for tests?

suhel.rangnekar’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
5.26 KB
FAILED: [[SimpleTest]]: [MySQL] 4,617 pass(es), 756 fail(s), and 108 exception(s). View

Patch is working on branch 7.x-2.x and drupal version 7.42-dev
Re-rolled!

Status: Needs review » Needs work
echoz’s picture

Fantastic! The #29 patch applied cleanly to Date 7.x-2.9 and works great, thanks so much to all who put this together.

Since I didn't patch this on dev, my testing is not qualified for RTBC. It seems it also needs tests to pass. I just wanted to add to the reports that it works.

Status: Needs work » Needs review

Status: Needs review » Needs work
aitala’s picture

Now if it works for Date 2.10 ...

E

echoz’s picture

patch #29 applies cleanly to Date 7.x-2.10 and seems to be working fine. I did not patch dev but that should apply too, needs tests.
I have been running #29 for a long time on 7.x-2.9 without issue.

aitala’s picture

Seems to work just fine.

Of course, going through my event nodes, the first instance of multiple occurrences I found was 2nd Tuesday and 4th Friday of the month. Heh.

Thanks,
Eric