when changing default duration settings, need to use default when per-taxonomy entry is blank.
per-taxonomy items need to be blank unless they are specifically overridden.

Comments

summit’s picture

Hi,

I am not getting any setting on taxonomy duration:
I got:

Taxonomy-dependent settings
Ad duration, in days, for the ads created in each category. Ads expire this many days after creation in this category - note that changing the category after creation will not change the expiration date unless the author resets the expiration. Ads assigned more than one category at the time of creation or editing receive the maximum duration found in all assigned categories. 

But not a setting.

greetings,
Martijn

mcurry’s picture

Category: bug » task
Priority: Minor » Normal

Making this a task. Please don't submit unrelated issues in this thread.

mcurry’s picture

Assigned: mcurry » Unassigned
fgm’s picture

Title: Fix Default Duration/per-taxonomy duration in settings - doesn't apply to taxonomy-dependent items » Fix Default Duration/per-taxonomy duration from settings - doesn't apply to taxonomy-dependent items
Version: 5.x-1.x-dev » 7.x-3.x-dev
Component: User interface » Code
Category: task » bug

The problem, if I understand it correctly, does not exist on 6.x-3.x / 7.x-3.x for the settings screen.

It does exist on 7.x-3.x for the actual node expiration, though: this is alway set to the default lifetime instead of the category-specific one. Reclassifying accordingly.

fgm’s picture

Status: Active » Needs work

Fixed in today's dev version. Need to add a test before it's completely fixed.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new3.92 KB

Status: Needs review » Needs work

The last submitted patch, expiration_per_term-143680-6.patch, failed testing.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new4.81 KB

Tests pass locally but fail on qa.drupal.org: rerolled with added include check to identify the specific qa.drupal.org problem.

Status: Needs review » Needs work

The last submitted patch, expiration_per_term-143680-8.patch, failed testing.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new14.16 KB

Yet another way to make it pass on qa.drupal.org.

Status: Needs review » Needs work

The last submitted patch, expiration_per_term-143680-9.patch, failed testing.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new14.36 KB

Yet one more attempt to make qa.drupal.org happy.

Status: Needs review » Needs work

The last submitted patch, expiration_per_term-143680-12.patch, failed testing.

fgm’s picture

Status: Needs work » Needs review
StatusFileSize
new15.14 KB

Actually, no need to depend on token, we just use the core token.inc implementation.

fgm’s picture

Status: Needs review » Fixed

Chx found the problem: the D7 version does not actually depend on token.module but token.inc, so the contrib dependency was not needed. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fgm’s picture

Status: Fixed » Patch (to be ported)

The classified_utils.inc removal part of that patch should be applied to 6.3 too, for consistency/maintenability.

fgm’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Closed (fixed) » Fixed

Fixed in today's dev version.

Status: Patch (to be ported) » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.