Hi,

line 335

$output .= theme('more_link', array('title' => t('more tags'), 'url' => "tagadelic/chunk/{$vars['voc']->vid}"));

Patch with ->

if(isset($vars['voc'])){
  if (count($terms) >= variable_get('tagadelic_block_tags_' . $vars['voc']->vid, 12)) {
    $output .= theme('more_link', array('title' => t('more tags'), 'url' => "tagadelic/chunk/{$vars['voc']->vid}"));
  }
  return $output;
}

Comments

Bèr Kessels’s picture

Status: Active » Closed (won't fix)

Issues for tagadelic are closed on Drupal.org. Please provide a pull-request or ticket on Github

Thanks for reporting, though!

GlobalRaj’s picture

I know the status says "Won't fix" but that Github is too confusing for me. So I am posting my issue here hoping for some help.

The tags block is working fine but when I click on "More" I end up with error.

    Notice: Undefined index: voc in theme_tagadelic_weighted() (line 334 of public_html/sites/all/modules/tagadelic/tagadelic.module).
    Notice: Trying to get property of non-object in theme_tagadelic_weighted() (line 334 of public_html/sites/all/modules/tagadelic/tagadelic.module).
    Notice: Undefined index: voc in theme_tagadelic_weighted() (line 335 of public_html/sites/all/modules/tagadelic/tagadelic.module).
    Notice: Trying to get property of non-object in theme_tagadelic_weighted() (line 335 of public_html/sites/all/modules/tagadelic/tagadelic.module).

Thanks & Cheers!
Raj Padhi

GlobalRaj’s picture

And yes, if I apply the above mentioned patch, the error doesn't show up but nor do the tags.

When I click on "More" after applying the patch, I end up with the following.

Page not found
The requested page "/tagadelic/chunk/1" could not be found.

I would just like to know if this one is being actively developed. If not, please let us know so I can just remove the module.

Thanks.
Raj Padhi

GlobalRaj’s picture

Status: Closed (won't fix) » Active
leonardo.drupal’s picture

I know that this issue is closed but just posting this here so that it will be helpful to anyone who is still facing this problem.

See the original post but instead of patching with the code given in the post slightly modify it and replace the following (lines 334 and 335 of the tagadelic.module file)

 if (count($terms) >= variable_get('tagadelic_block_tags_' . $vars['voc']->vid, 12)) {
    $output .= theme('more_link', array('title' => t('more tags'), 'url' => "tagadelic/chunk/{$vars['voc']->vid}"));
  }

with the following

if(isset($vars['voc'])){
if (count($terms) >= variable_get('tagadelic_block_tags_' . $vars['voc']->vid, 12)) {
$output .= theme('more_link', array('title' => t('more tags'), 'url' => "tagadelic/chunk/{$vars['voc']->vid}"));
}}

Now you shouldn't get the error mentioned in #3

leo

WriteCo’s picture

Thank you, Leo!

blglbrth’s picture

Thank you Leo.

albertguedes’s picture

Tanks leonardo.drupal , your tip work perfectly.

Bèr Kessels’s picture

Status: Active » Closed (won't fix)

Please do not change the status!

hitesh-jain’s picture

Thanks leo...........grt work

joverstreet’s picture

Used #5 fix for the issue. Works great! Thanks Leo!

Triumphent’s picture

Great fix Leo, thank you..! :)

kringf’s picture

Thank you Leo, the fix works for me as well

raulmuroc’s picture

Status: Closed (won't fix) » Active

For me is not working... the block just doesn't show anything at all. :S

Could someone pass me a tagadelic module zipped?? I tried everything and nothing works to raise up a tagged list.

Bèr Kessels’s picture

Status: Active » Closed (won't fix)

Please do not change the status!

raulmuroc’s picture

Ok... but anyway this is not working.

digibrill’s picture

Great Leo!

objredline’s picture

I had all 4 errors on the /tagadelic page, Leo your code fixes it. Thanks!!!

Bèr Kessels’s picture

As you all may, or may not know, this has long been fixed in the development-version over at https://github.com/berkes/tagadelic/commits/7.x-1.x

There are some other issues that need solving, because Leo's "patch" is but an ugly hack (Sorry Leo) and we'd rather fix this properly with a solid refactoring.

But, head over there, pick the latest if you feel adventurous. But you probably feel that anyway, since you all are using a unreleased, unstable and shipped-with-no-upgrade-paths module. But you probably already know why you should never run -dev releases in production.

jenlampton’s picture

Status: Closed (won't fix) » Active

Can we please get a stable version released on drupal.org ASAP, with an active issue queue here where people can participate?
Thanks :)

Bèr Kessels’s picture

Status: Active » Closed (won't fix)

If you want a release, then please do not require my (precious) time by forcing me to administrate bugs that I have closed. That is counterproductive.

If you want a release, write code, send pull-requests, fix issues and whatnot.

HypervisedEd’s picture

I'm also having this error, its completely saturating my server's logs.

Since the developer of this module is clearly not interested in the development of Drupal can anyone recommend a similar module that is stable and is supported by someone who cares?

Bèr Kessels’s picture

Tickets and bug-reports are not the right place for nasty remarks.

Since the developer of this module is clearly not interested in the development of Drupal can anyone recommend a similar module that is stable and is supported by someone who cares?

http://berk.es/2013/02/10/tagadelic-tdd-oop-and-seeking-maintainer/

I've been developing a new version for the last several months. Therefore your remark is not only wrong, it is nasty and completely out of place. FUD.

Bèr Kessels’s picture

Issue summary: View changes

added code tags for sanity