Avoid duplicate messages for "one of several" validation type [#1433960]

When using a group of validation rules for checking that at least one of several fields is not empty, the error message is displayed more than once if the validation fails.

Comment	File	Size	Author
#4	field_validation-avoid-duplicate-messages-one-of-several-1433960-4.patch	2.56 KB	b-prod
#1	field_validation-avoid-duplicate-messages-one-of-several-1433960-1.patch	1.85 KB	b-prod

Comments

Comment #1

b-prod commented 9 February 2012 at 10:29

Status:

Active

» Needs review

Status	File	Size
new	field_validation-avoid-duplicate-messages-one-of-several-1433960-1.patch	1.85 KB

The patch below fixes such issue. But due to a Drupal core bug that is discussed here (#289452: FAPI: Error class is not set if error message is empty), the following patch against Drupal core need to be applied: http://drupal.org/node/289452#comment-3039426.

The question is: should we test that the patch has been applied and provide a fallback behavior if not?
It could be quite simple by calling form_get_error($element) after havin thrown an empty message. If it return an empty string, we can consider that the patch was not applied anf call again form_error() with the message.

But I am not sure that adding more code to handle Drupal core issue is a good thing. Moreover, only the "one of several" validation rules are concerned by this Drupal bug.

Comment #2

Anonymous (not verified) commented 23 August 2012 at 17:31

Version:

7.x-1.x-dev

» 7.x-2.x-dev

Hi B-Prod, thanks for providing a patch for this. Unfortunately it does not apply to 7.x-2.x-dev - any chance you could re-roll it?

Comment #3

FreeFox commented 26 August 2012 at 16:10

I want to second this request. However, patching the core is 1 thing I'm not allowed to do. Is it possible to patch only the validation module to do the trick?

Thanks in advance. Keep up the good work.