The theme function which displays the UPS shipping label incorrectly obtains the stream URI of the image file, and also fails to convert it to a linkable URL before embedding it. Patch to follow momentarily.

CommentFileSizeAuthor
#1 ubercart-broken-label-1430850-0.patch742 bytesjerry
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jerry’s picture

jerry CreditAttribution: jerry commented
Status: Active » Needs review
FileSize
ubercart-broken-label-1430850-0.patch742 bytes

Patch attached.

TR’s picture

TR CreditAttribution: TR commented
Status: Needs review » Fixed

Thanks for finding that. I can't test it because I don't have permissions from UPS to generate shipping labels, but your changes are consistent with what I use for the FedEx equivalent function in my uc_fedex module.

Clearly, UPS shipping label generation is not something that's used by many people since that bad code has been present for the past 11 months without anyone reporting a bug!

Patch committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.