On unsubscribe of a mail address some things are still pretty unclean...
In simplenews.module
function simplenews_unsubscribe_user
We should reuse the existing subscriber object and not define a new one.
$subscriber->newsletter_subscription[$tid']
Also the subscriber should not finally contain
$subscriber->tids[$tid] = $tid;
It should be unset.
Also the $subscriber->newsletter_subscription is not continued (set, unset) correctly ... This affects unsubscribe and subscribe.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cleanup.patch | 2.64 KB | berdir |
Comments
Comment #1
berdirThe attached patch cleans this up a bit and also adds tests to actually verify that subscribe/unsubscribe works with single opt-in. The old code actually didn't have any useful assertions ;)
Note that the tests don't actually verify these changes. The only way to verify this would be to add a test module and implement those hooks, because that is the only way where the incomplete/wrong $subscriber object is actually available.
Comment #2
miro_dietikerLooks fine, consistent now. Thank you for fixing this.
Comment #3
berdirCommited.