I just noticed that it is enabled by default.

It should be disabled by default.

In order to change the value to disabled, I had to enter in a bogus ID in the VWO ID box for my settings to save

Comments

elc’s picture

Title: It should be disabled by default » Module should be disabled by default on install
Status: Active » Closed (won't fix)

Due to the on/off settings not being present in the original version, the on/off switch has to be enabled by default so as not to break installations that update but do not save the setting. Prior to this feature being added, the only way to turn off the module was to disabled the entire module.

When the ID is not set, it is the same as turning off the module. It's the same line of code that does the check. When first installed, the ID is set to 'NONE' and enabled to 'on'. In this state, it is the same as turning off the module. When someone has previously set the Account ID, the settings become the ID and 'on', thus allowing it to continue to function without any changes after an update.

From hook_init():

  // If the code is not set, or the module is not enabled, do not check filters.
  if ($settings['id'] == 'NONE' || $settings['enabled'] == 'off') {
    return;
  }

An alternative might be to allow the code to be empty, but then people might not notice that they need to include the ID for anything to happen.

socialnicheguru’s picture

Place in big bold letters that you need to enter the key in order for the module to work.

elc’s picture

Part of the 7.x-1.x-dev (and 6.x-1.x-dev) branch at present is considerably more direction and user assistance, including a rather clear instruction that an Account ID is required and a link to go get one. At the same time, the project home page was updated to also reflect this.

From the settings page:

Visual Website Optimizer is an easy to use A/B, split and multivariate testing tool.

In order to use this module, you will need a Visual Website Optimizer account. A Free 30 day trial account is available from the VWO webite by clicking on either of the links below. To contribute towards the continued development of this module for free and with no effort, click on the affilitate link. Otherwise, click the other link without the affiliate marker.

Sign up for a Free 30 day trial account AND help out, or Sign up for a Free 30 day trial without affiliate link.

Once the Account ID has been set on this page, the configuration of your A/B and other tests is done by logging into your account on the VWO website.

If you could grab that release and double check that its new functionality works as expected, I can roll it into a 1.1 release so that everyone may benefit.

elc’s picture

Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Assigned: Unassigned » elc
Category: bug » feature
Status: Closed (won't fix) » Fixed
Issue tags: +added to 1.2-dev

Added the ability to set the Account ID back to the installed default of 'NONE' so that a numerical dud value does not need to be entered.

The module is still disabled by default upon install by simply having the Account ID set to NONE, but it made sense to be able to set it back to the same value for completeness.

Automatically closed -- issue fixed for 2 weeks with no activity.