Closed (fixed)
Project:
Visual Website Optimizer
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
31 Jan 2012 at 13:23 UTC
Updated:
4 Jan 2014 at 01:39 UTC
Jump to comment: Most recent
Comments
Comment #1
elc commentedDue to the on/off settings not being present in the original version, the on/off switch has to be enabled by default so as not to break installations that update but do not save the setting. Prior to this feature being added, the only way to turn off the module was to disabled the entire module.
When the ID is not set, it is the same as turning off the module. It's the same line of code that does the check. When first installed, the ID is set to 'NONE' and enabled to 'on'. In this state, it is the same as turning off the module. When someone has previously set the Account ID, the settings become the ID and 'on', thus allowing it to continue to function without any changes after an update.
From hook_init():
An alternative might be to allow the code to be empty, but then people might not notice that they need to include the ID for anything to happen.
Comment #2
socialnicheguru commentedPlace in big bold letters that you need to enter the key in order for the module to work.
Comment #3
elc commentedPart of the 7.x-1.x-dev (and 6.x-1.x-dev) branch at present is considerably more direction and user assistance, including a rather clear instruction that an Account ID is required and a link to go get one. At the same time, the project home page was updated to also reflect this.
From the settings page:
If you could grab that release and double check that its new functionality works as expected, I can roll it into a 1.1 release so that everyone may benefit.
Comment #4
elc commentedAdded the ability to set the Account ID back to the installed default of 'NONE' so that a numerical dud value does not need to be entered.
The module is still disabled by default upon install by simply having the Account ID set to NONE, but it made sense to be able to set it back to the same value for completeness.