This is just to try and clean up the code to help resolve any problems.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | php-errors-code-cleanup-1420570-5.patch | 16.62 KB | wojtha |
| #5 | interdiff.txt | 11.25 KB | wojtha |
| #4 | php-errors-code-cleanup-1420570-3.patch | 16.38 KB | wojtha |
| #3 | php-errors-code-cleanup-1420570-2w.patch | 32.22 KB | wojtha |
| #3 | interdiff.txt | 20.38 KB | wojtha |
Comments
Comment #1
NROTC_Webmaster commentedHere is a patch for the module file and the install file
Comment #2
NROTC_Webmaster commentedComment #3
wojtha commentedAdditionally fixed:
if/else/while/foreachstatemets.t()or with faulty formatted strings (e.g. in the hook_help)_php_errors_get_roles_emails(), now it usesdb_placeholders()to properly cleanup the user roles in thedb_query().splitandjoinreplaced byimplodeandexplode.count()replaced by!empty()where possible (its more safe and less CPU intensive).Plus fixed the following bug which will cause undesired behavior:
(Break will do nothing since we are not inside the loop so the code will continue to execute.)
Comment #4
wojtha commentedThe INFO file needs cleanup as well.
PS: Just noticed that my patches in the previous comment has wrong encoding and line endings, sorry for that.
Comment #5
wojtha commentedAdditionally fixed:
Interdiff is against #1.