Lots of menu blocks can really clutter up the "Miscellaneous" category in Panels, and they would be much more sensibly assigned to the existing "Menus" category.

CommentFileSizeAuthor
#3 ctools_block_info-1420180-3.patch546 bytesjweowu
#3 ctools_block_info_for_2.2-1420180-3.patch514 bytesjweowu
#2 ctools_block_info_for_2.2-1420180-2.patch607 bytesjweowu
#1 ctools_block_info-1420180.patch669 bytesjweowu

Comments

jweowu’s picture

jweowu commented
Status: Active » Needs review
StatusFileSize
new ctools_block_info-1420180.patch669 bytes
jweowu’s picture

jweowu commented
StatusFileSize
new ctools_block_info_for_2.2-1420180-2.patch607 bytes

And here's a copy of #1 which applies cleanly to menu_block 7.x-2.2

jweowu’s picture

jweowu commented
StatusFileSize
new ctools_block_info_for_2.2-1420180-3.patch514 bytes
new ctools_block_info-1420180-3.patch546 bytes

That was a straight copy of menu_ctools_block_info() from ctools/plugins/content_types/block/block.inc, and in retrospect the $delta check for primary/secondary links wasn't relevant here, as all menu_block $delta values are numeric.

aendra’s picture

aendra commented

Needs to be updated for 2.3. Code works, though; I basically copied it in a separate module and it works as intended.

However, if ever this code gets moved upstream, would it be possible to implement it via its own hook instead of just an implementation of hook_ctools_block_info? That way users would be able to override the default values (I.e., category) by writing their own function. See: http://drupal.stackexchange.com/questions/41983/setting-panels-category-...

jweowu’s picture

jweowu commented

aendrew: That sounds like a feature request for ctools; you should post it in its issue queue.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Category: bug » feature
Status: Needs review » Closed (works as designed)

Menu block's "menu tree" panes already do appear in the Panels' “Menus" category. See menu_block_menu_tree_content_type_content_types()

jweowu’s picture

jweowu commented

Well fourteen months ago they didn't, but that's all good then :)

jweowu’s picture

jweowu commented
Status: Closed (works as designed) » Needs review

Ah, no, you've misunderstood.

This patch is for menu_block blocks, not panes.

Ctools provides panes for all defined blocks. This patch makes sure that the panes it defines for menu_block blocks will appear in the Menus category rather than the Miscellaneous category.

jweowu’s picture

jweowu commented
Title: Assign menu block panel panes to "Menus" category. » Assign the panel panes for menu block blocks to the "Menus" category.

Apologies; that title was misleading.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Fixed

Oh! I see.

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.