Please review this patch... I've spent the last 4-5 hours cleaning up the code and now it passes through Coder Review, has more robust standards, is more clear to work with etc. You have to see it to believe it.

CommentFileSizeAuthor
#2 errorpatchapplycrev2.png54.05 KBagill
#2 errorpatchapplycrev.png46.72 KBagill
coder-review.patch979.16 KBpetsagouris

Comments

petsagouris’s picture

petsagouris commented

Furthermore, somewhere in these edits, I have fixed the bug described in #1406706: Undefined index, it was a trivial bug.

@@ -291,7 +288,7 @@ function agres_availability_menu_local_tasks_alter(&$data, $router_item, $root_p
         // links to the other views will have been adjusted to keep information
         // about the right year/month/week/day to go to.
         $item['href'] = $tab['path'];
-        if ($item['access']) {
+        if (isset($item['access'])) {
           $data['tabs'][0]['output'][$delta] = array(
             '#theme' => 'menu_local_task',
             '#link' => $item,
agill’s picture

agill commented
StatusFileSize
new errorpatchapplycrev.png46.72 KB
new errorpatchapplycrev2.png54.05 KB

Hello George, thanks alot for your effort!
I tried applying this patch with git -v apply coder-review.patch
but i get several error messages.
When did you download the version of agreservations you made the
coder-review changes on?

I hope we can fix the problem so i can apply your patch and test.

If not, i will use the coder-upgrade module to clean up and
fix the bug from issue 1406706 manually.
Thanks again for your help George!

Andreas

petsagouris’s picture

petsagouris commented

Searching around the problem you mentioned I found that the patch attached to the first post can be applied with
patch -p1 < coder-review.patch

agill’s picture

agill commented

I applied your patch. Thanks for your help!

petsagouris’s picture

petsagouris commented
Status: Needs review » Fixed

Alright, thanks a lot. Please next time, be sure to include proper commit author, you can find the attribute to attach to the commit command on the user's profile page, under the Git Attribution section. (see Proper Git Attribution)

agill’s picture

agill commented

you are right George, i guess i was so used to work on this alone
that i did not pay attention to the authorship option in git. I did a commit
with a message that sort of corrects the authorship for the patch commit
at least its mentioned now in the commit message of todays git commit. Next patches will be aplied
properly with correct authorship.

Regards,
Andreas

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.