The module works great except for the fact that the breadcrumb doesn't get set. Seems weird, is there a setting I'm just forgetting to check?


Dmitriy.trt’s picture

Breadcrumbs were set because of static cache hacks we used in 7.x-1.x branch. The new 7.x-2.x branch is finally using stable API to set active trail, but it seems this new method has no effect on breadcrumbs (I've not checked it yet). So, I'm still not sure if it's really necessary for this module to set breadcrumbs. And things become even more complicated, because 7.x-2.x will support multiple active trails in the near future (separate active trail for each menu). I'll think about setting breadcrumbs too, but probably it will be better for each module to do its job only. "Unix way" is the right way in my opinion. We have a great Custom Breadcrumbs module and we really don't want to re-implement its features in Taxonomy Menu Trails.

If I'm missing something and Taxonomy Menu Trails must set breadcrumbs, if this solution will have some benefits over using other module for this purpose, please let me know.

aiquandol’s picture

It just seems natural that a module which sets the menu path would also set the breadcrumb, as they're intricately linked in the drupal core. Maybe if Drupal itself clearly distinguished between breadcrumbs and menu items through its administration I would agree more with this approach.

I understand where you're coming from, but as a webmaster/developer I fear using 2 modules to modify the menu system in the same way seems awkward at best. For now I'll go ahead and use Custom Breadcrumbs but I think this point will be brought up again.

Thanks for all your hard work!

Dmitriy.trt’s picture

Status: Active » Needs work

OK, I've implemented optional breadcrumb modification by TMT when active trail was set based on node's term. Feature is enabled by default and only affects default breadcrumb generated by core menu system, so it should not modify breadcrumb generated by third-party modules. It adds active trail links to the front of existing breadcrumb, but right after "Home" link if any. There is a possible problem with this behavior when node page itself is in menu, I'll fix it in the next few days.

aiquandol’s picture

Awesome! Thanks a bunch, this should be really nice. I've been using this module combined with custom breadcrumbs and it's a pretty big headache :) It will be great to have that all combined and simplified.

Dmitriy.trt’s picture

Status: Needs work » Needs review

Committed final changes to 7.x-2.x, please wait for the next dev version build or checkout from git and test it. Breadcrumb option is extended to set breadcrumb always, when original is empty (default behavior now) or never. "Empty" here means there are no items between "Home" (or breadcrumb start) and current tab root menu item. Please don't forget to run update.php.

The plan is to release stable 7.x-2.0 version tomorrow.

Dmitriy.trt’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.