I added some form elements inside tableselect element including checkboxes (how: http://drupal.org/node/1396320#comment-5508506).
When I click "Select all" checkbox, all checkboxes within the table are affected.

CommentFileSizeAuthor
#32 1415320-32.patch2.15 KBmyha
#31 1415320-31.patch3.27 KBmyha
#20 1415320-20.patch3.23 KBgrathbone
#15 1415320-15.patch3.32 KBgrathbone
#1 tableselect_target_select_all-1415320-1.patch621 bytesleksat

Comments

leksat’s picture

leksat commented
Status: Active » Needs review
StatusFileSize
new tableselect_target_select_all-1415320-1.patch621 bytes

Attached patch solves the problem by modifying jQuery selector from

td input:checkbox:enabled

to

td:first-child input:checkbox:enabled
heine’s picture

heine commented
Status: Needs review » Closed (duplicate)

Thanks.

This is a duplicate of #1319420: multiple execution of tableselect.js with nested tables.

leksat’s picture

leksat commented
Status: Closed (duplicate) » Needs review

@Heine, I wouldn't be so sure. The issue you provided describes a totally different problem.

heine’s picture

heine commented

You are right. I'm sorry.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript

The patch might work but it relies on checkboxes being on the first column, is that always the case? (i'm thinking about user permission table)

leksat’s picture

leksat commented

User permissions table uses theme_table(), not a theme_tableselect().
Tableselect form element always puts its checkboces into first column.
From theme_tableselect():

      // Render the checkbox / radio element.
      $row['data'][] = drupal_render($element[$key]); // ALWAYS FIRST

      // As theme_table only maps header and row columns by order, create the
      // correct order by iterating over the header fields.
      foreach ($element['#header'] as $fieldname => $title) {
        $row['data'][] = $element['#options'][$key][$fieldname]; // THEN ALL OTHERS
      }
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work

needs reroll, jQuery selector changed, also 8.x

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Postponed (maintainer needs more info)

Can I get a confirmation for D8? shouldn't happen any more.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes

Updated issue summary.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

grathbone’s picture

grathbone commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Needs work

Selecting the first item doesn't seem to be a viable solution, especially since Views BulkForm allows positioning the table-select element in any column. The patch in #1 breaks BulkForm.

grathbone’s picture

grathbone commented
Version: 8.5.x-dev » 8.6.x-dev
StatusFileSize
new 1415320-15.patch3.32 KB

Wrote a patch that checks the index of the checkboxes before they are updated.

grathbone’s picture

grathbone commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: 1415320-15.patch, failed testing. View results

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

grathbone’s picture

grathbone commented
Status: Needs work » Needs review
StatusFileSize
new 1415320-20.patch3.23 KB

Rerolled for 8.7.x.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Issue tags: -JavaScript +JavaScript

Saw this as the nightly bug on slack. Anyone have testing steps for this?

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative, +Needs steps to reproduce

@grathbone Could you provide steps to reproduce? And could you verify this is still a problem?

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Wow, 10 years @nod_asked if this was reproducible on Drupal 8. There was no replay, although a patch was worked on. Seven months ago steps to reproduce were asked for. Again, no reply. Since we need more information to investigate the report and none has been provided, I am closing this issue.

myha’s picture

myha commented
StatusFileSize
new 1415320-31.patch3.27 KB

Rerolled for 9.5.x.

myha’s picture

myha commented
StatusFileSize
new 1415320-32.patch2.15 KB

Rerolled for 10.2.x.