While experimenting with this module I noticed a few php warnings.

The validator code in the 'tweets' view calls twitter_twitter_accounts() while the user_load() already fetched the desired records.

This patch would save a database query. And a php warning when no $uid is found.

Comments

helmo’s picture

Previous patch was missing a check....

davidneedham’s picture

Seems like a good patch. Can you re-roll against 7.x-5.x?

davidneedham’s picture

Title: Duplicate load of twitter accounts » Eliminate extraneous query on loading account info
helmo’s picture

No, I currently don't use this module anymore. Sorry, but unless a client asks for it.... I'm short on time.

davidneedham’s picture

Status: Needs review » Closed (fixed)

No problem. Pretty sure the module was completely re-written between the 3.x and 5.x anyway, so I'll go ahead and close this ticket.