After enabeling the language module I was able to edit the english language and make it "right to left".
But the "right to left" stylsheets weren't added to the source.
I noticed that the rtl stylesheet system only works when locale is enabled.

This sounds like a major WTF. We shouldn't add options in one module if they don't work without enabling another one.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

first should fail, second one will pass

aspilicious’s picture

Status: Active » Needs review
aspilicious’s picture

I added an extra newline (by accident), will remove that in a next reroll

xjm’s picture

Awesome! Nice simple fix. Going to wait and see what the bot is, though. This seems borderline major, but @aspilicious and I decided to check with Gabor.

xjm’s picture

Issue tags: +Needs tests

Hmm, the version without the test fix also passed. Looks like we do need more test coverage.

aspilicious pointed out that locale requires language; duh. So the test passed anyway.

aspilicious’s picture

FileSize
671 bytes

Locale requires language so 1 en 1B will always succeed...

I guess this new file should fail...

Status: Needs review » Needs work

The last submitted patch, 1405604-should-fail.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
FileSize
3.04 KB

Ok, now I'm happy.
So this patch is the same as 1b without the extra newline.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests +D8MI

Good catch. This was certainly a miss when the language related code was moved to language.module. Looks good, it is just a 1-1 move of a hook.

BTW Another related issues where we are making node and path module closer to rely only on language module for their language services (vs. locale module) is #1387608: Unify language_list() and locale_language_list(), help welcome :)

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Looks good and was clearly an oversight in an earlier patch. Committed to 8.x. Thanks.

Gábor Hojtsy’s picture

Issue tags: +language-base

Tagging for base language system.

Automatically closed -- issue fixed for 2 weeks with no activity.