Closed (fixed)
Project:
Commerce Core
Version:
7.x-1.x-dev
Component:
Price
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Jan 2012 at 12:06 UTC
Updated:
31 Jan 2012 at 03:00 UTC
The %-placeholder already check_plains content by default, so there is no need to explicitly check_plain() the value in commerce_price_field_validate() (doing so will cause double-escaping).
$errors[$field['field_name']][$langcode][$delta][] = array(
'error' => 'price_numeric',
'message' => t('%name: you must enter a numeric value for the price.', array('%name' => check_plain($instance['label']))),
);
| Comment | File | Size | Author |
|---|---|---|---|
| redundant-check-plain-price-validation.patch | 745 bytes | mr.baileys |
Comments
Comment #1
rszrama commentedIndeed! This appears to be the only place in the code where this mistake occurs, but feel free to post another patch if you turn more up. Committed. : )