Hi,
Thanks for the module. I have translations installed and need the language separation, you check for the language for the cache variable, but never distinguish between the tags in languages in your query. I had prepared a patch, but you disabled the PDO query, are you going to enable it again?

CommentFileSizeAuthor
#3 [tagclouds]-[language-separated-tags]-[1404124]-[5478992].patch1.36 KBreptilex

Comments

MGParisi’s picture

MGParisi commented

PDO is beign used on lines 202->213, which SQL statement are you referring too? I will patch it and release a new version if you write it.

reptilex’s picture

reptilex commented

Here the patch, I just add a language checker, then a form checkbox for separation if more languages are enabled and according to that variable I add an sql condition.

reptilex’s picture

reptilex commented
StatusFileSize
new [tagclouds]-[language-separated-tags]-[1404124]-[5478992].patch1.36 KB

sorry forgot the file

reptilex’s picture

reptilex commented

I was using the wrong version in git so I had a patch against some obscure dev status. So I corrected it. I hope you can use my patch I really need this and would hate having to hack your code on my site for each update.

MGParisi’s picture

MGParisi commented

Its on my to do list, been busy. Can you send a corrected patch with the "right" version of git?

reptilex’s picture

reptilex commented

The patch was made against the git commit version for tag 7.x-1.1. Am i not using the right version now? Like I said I WAS using the "wrong" version, now it should be the "correct" one.

If this is not the right tag, which version should I use?

MGParisi’s picture

MGParisi commented

The patch was not right, but I manually applied it and the patch should be in the latest dev version (when its updated)

MGParisi’s picture

MGParisi commented

http://drupal.org/node/1282854/commits as soon as I navigate git Ill put it as a dev release.

Thanks

MGParisi’s picture

MGParisi commented
Status: Active » Fixed

should get rolled in the next release cycle on the dev branch! Works locally, please test. Feel free to submit translations.

reptilex’s picture

reptilex commented

Thanks for including it, sorry for the extra work. I'll see if I get some translations going soon.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit bd0358e on 7.x-1.x, 8.x-1.x by MGParisi: 
    Issue #1404124 by reptilex: added Language Separation